Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-27 Thread Bryan O'Donoghue
On 26/05/2025 17:23, Vincent Knecht wrote: Do you mean to just rename to vfe_vbif_write_reg() Yep, its more natural language. --- bod

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-27 Thread Bryan O'Donoghue
On 26/05/2025 17:20, Vincent Knecht wrote: You have both if (vfe->res->has_vbif) { and the above switch, there's no point in checking this twice in two different ways. Choose one, suggest has_vbif is enough. I think the switch is still needed, so that distinct settings can be applied for diff

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-26 Thread Vincent Knecht
Le lundi 26 mai 2025 à 09:13 +0100, Bryan O'Donoghue a écrit : > On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote: > > +void vfe_vbif_reg_write(struct vfe_device *vfe, u32 reg, u32 val); > > write_reg() / read_reg() > > --- > bod Do you mean to just rename to vfe_vbif_write_reg(), or that

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-26 Thread Bryan O'Donoghue
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote: From: Vincent Knecht Some devices need writing values to VFE VBIF registers. Add helper functions to do this. Signed-off-by: Vincent Knecht --- drivers/media/platform/qcom/camss/Makefile | 1 + drivers/media/platform/qcom/cam

Re: [PATCH v2 1/4] media: qcom: camss: vfe: Add VBIF setting support

2025-05-26 Thread Bryan O'Donoghue
On 25/05/2025 20:25, Vincent Knecht via B4 Relay wrote: +void vfe_vbif_reg_write(struct vfe_device *vfe, u32 reg, u32 val); write_reg() / read_reg() --- bod