Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

2013-06-19 Thread Guenter Roeck
On Wed, Jun 19, 2013 at 11:03:46AM -0700, Kevin Strasser wrote: > On Wed, Jun 19, 2013 at 11:12:09AM +0200, Thomas Gleixner wrote: > > On Tue, 18 Jun 2013, Kevin Strasser wrote: > > > > This patch set looks reasonable now, except a formal issue. > > > > > Signed-off-by: Kevin Strasser > > > Sig

Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

2013-06-19 Thread Kevin Strasser
On Wed, Jun 19, 2013 at 11:12:09AM +0200, Thomas Gleixner wrote: > On Tue, 18 Jun 2013, Kevin Strasser wrote: > > This patch set looks reasonable now, except a formal issue. > > > Signed-off-by: Kevin Strasser > > Signed-off-by: Michael Brunner > > This is wrong, as it says: > > Kevin autho

Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

2013-06-19 Thread Mark Brown
On Wed, Jun 19, 2013 at 11:11:27AM +0200, Samuel Ortiz wrote: > On Wed, Jun 19, 2013 at 10:40:04AM +0200, Linus Walleij wrote: > > Not really my business, but I think if I was to implement this > > inter-module API I would use regmap for this read/write marshalling > > right here. > I thought abo

Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

2013-06-19 Thread Thomas Gleixner
On Tue, 18 Jun 2013, Kevin Strasser wrote: This patch set looks reasonable now, except a formal issue. > Signed-off-by: Kevin Strasser > Signed-off-by: Michael Brunner This is wrong, as it says: Kevin authored the code, sent it to Michael and Michael sent it to LKML. The original code wa

Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

2013-06-19 Thread Samuel Ortiz
Hi Linus, On Wed, Jun 19, 2013 at 10:40:04AM +0200, Linus Walleij wrote: > On Tue, Jun 18, 2013 at 11:04 PM, Kevin Strasser > wrote: > > Add core MFD driver for the on-board PLD found on some Kontron embedded > > modules. The PLD device may provide functions like watchdog, GPIO, UART > > and I2C

Re: [PATCH v2 1/4] mfd: Kontron PLD mfd driver

2013-06-19 Thread Linus Walleij
On Tue, Jun 18, 2013 at 11:04 PM, Kevin Strasser wrote: > Add core MFD driver for the on-board PLD found on some Kontron embedded > modules. The PLD device may provide functions like watchdog, GPIO, UART > and I2C bus. > > The following modules are supported: > * COMe-bIP# > * COMe