Re: [PATCH v2 1/4] reset: Add support for the Amlogic Meson SoC Reset Controller

2016-05-30 Thread Philipp Zabel
Hi Kevin, Am Donnerstag, den 26.05.2016, 11:42 -0700 schrieb Kevin Hilman: [...] > > Personally, I'd prefer if the driver could switch to only using > > reset_control_reset(rstc); > > Then what would happen if that same driver is used on platforms that > have ->assert and ->deassert but no -r

Re: [PATCH v2 1/4] reset: Add support for the Amlogic Meson SoC Reset Controller

2016-05-26 Thread Kevin Hilman
Philipp Zabel writes: > Am Mittwoch, den 25.05.2016, 19:42 -0700 schrieb Kevin Hilman: >> Neil Armstrong writes: >> >> > This patch adds the platform driver for the Amlogic Meson SoC Reset >> > Controller. >> > >> > The Meson8b and GXBB SoCs are supported. >> > >> > Signed-off-by: Neil Armstron

Re: [PATCH v2 1/4] reset: Add support for the Amlogic Meson SoC Reset Controller

2016-05-26 Thread Philipp Zabel
Hi Kevin, Am Mittwoch, den 25.05.2016, 19:42 -0700 schrieb Kevin Hilman: > Neil Armstrong writes: > > > This patch adds the platform driver for the Amlogic Meson SoC Reset > > Controller. > > > > The Meson8b and GXBB SoCs are supported. > > > > Signed-off-by: Neil Armstrong > > Maybe a questio

Re: [PATCH v2 1/4] reset: Add support for the Amlogic Meson SoC Reset Controller

2016-05-25 Thread Philipp Zabel
Hi Neil, looks fine, just two comments below. Am Mittwoch, den 25.05.2016, 11:49 +0200 schrieb Neil Armstrong: > This patch adds the platform driver for the Amlogic Meson SoC Reset > Controller. > > The Meson8b and GXBB SoCs are supported. > > Signed-off-by: Neil Armstrong > --- > drivers/res