Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-05 Thread Mark Brown
On Thu, Nov 05, 2015 at 05:59:36PM +0530, Vignesh R wrote: > On 11/04/2015 08:09 PM, Mark Brown wrote: > > It's a bit worrying that this doesn't sync with the message queue except > > via the mutex: this means that we might be out of order with respect to > > any asynchronous transfers that are ha

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-05 Thread Vignesh R
On 11/04/2015 08:09 PM, Mark Brown wrote: > On Tue, Nov 03, 2015 at 03:36:10PM +0530, Vignesh R wrote: > >> +} >> +mutex_lock(&master->mmap_lock_mutex); >> +ret = master->spi_mtd_mmap_read(spi, from, len, retlen, buf, >> +read_opcode, addr_width, >

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-04 Thread Mark Brown
On Tue, Nov 03, 2015 at 03:36:10PM +0530, Vignesh R wrote: > + } > + mutex_lock(&master->mmap_lock_mutex); > + ret = master->spi_mtd_mmap_read(spi, from, len, retlen, buf, > + read_opcode, addr_width, > + dummy_byt

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-03 Thread Vignesh R
Hi, On 11/03/2015 04:49 PM, Michal Suchanek wrote: > On 3 November 2015 at 11:06, Vignesh R wrote: >> In addition to providing direct access to SPI bus, some spi controller >> hardwares (like ti-qspi) provide special memory mapped port >> to accesses SPI flash devices in order to increase read pe

Re: [PATCH v2 1/5] spi: introduce mmap read support for spi flash devices

2015-11-03 Thread Michal Suchanek
On 3 November 2015 at 11:06, Vignesh R wrote: > In addition to providing direct access to SPI bus, some spi controller > hardwares (like ti-qspi) provide special memory mapped port > to accesses SPI flash devices in order to increase read performance. > This means the controller can automatically