Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-04-02 Thread Adrian Hunter
On 2/04/19 10:59 AM, Faiz Abbas wrote: > Hi Adrian, > > On 26/03/19 1:03 PM, Adrian Hunter wrote: >> On 18/03/19 11:33 AM, Ulf Hansson wrote: >>> + Arnd, Grygorii >>> >>> On Fri, 15 Feb 2019 at 20:17, Faiz Abbas wrote: sdhci.c has two bottom halves implemented. A threaded_irq for handli

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-04-02 Thread Faiz Abbas
Hi Adrian, On 26/03/19 1:03 PM, Adrian Hunter wrote: > On 18/03/19 11:33 AM, Ulf Hansson wrote: >> + Arnd, Grygorii >> >> On Fri, 15 Feb 2019 at 20:17, Faiz Abbas wrote: >>> >>> sdhci.c has two bottom halves implemented. A threaded_irq for handling >>> card insert/remove operations and a tasklet

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-26 Thread Adrian Hunter
On 18/03/19 11:33 AM, Ulf Hansson wrote: > + Arnd, Grygorii > > On Fri, 15 Feb 2019 at 20:17, Faiz Abbas wrote: >> >> sdhci.c has two bottom halves implemented. A threaded_irq for handling >> card insert/remove operations and a tasklet for finishing mmc requests. >> With the addition of external

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-18 Thread Ulf Hansson
+ Arnd, Grygorii On Fri, 15 Feb 2019 at 20:17, Faiz Abbas wrote: > > sdhci.c has two bottom halves implemented. A threaded_irq for handling > card insert/remove operations and a tasklet for finishing mmc requests. > With the addition of external dma support, dmaengine APIs need to > terminate in

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-14 Thread Faiz Abbas
Hi, On 14/03/19 4:45 PM, Grygorii Strashko wrote: > > > On 12.03.19 19:30, Rizvi, Mohammad Faiz Abbas wrote: >> Hi Adrian, >> >> On 3/8/2019 7:06 PM, Adrian Hunter wrote: >>> On 6/03/19 12:00 PM, Faiz Abbas wrote: Adrian, On 25/02/19 1:47 PM, Adrian Hunter wrote: > On 15/02/19

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-14 Thread Arnd Bergmann
On Tue, Mar 12, 2019 at 6:32 PM Rizvi, Mohammad Faiz Abbas wrote: > On 3/8/2019 7:06 PM, Adrian Hunter wrote: > > On 6/03/19 12:00 PM, Faiz Abbas wrote: > > It is a performance drop that can be avoided, so it might as well be. > > Splitting the success path from the failure path is common for I/O

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-14 Thread Grygorii Strashko
On 12.03.19 19:30, Rizvi, Mohammad Faiz Abbas wrote: > Hi Adrian, > > On 3/8/2019 7:06 PM, Adrian Hunter wrote: >> On 6/03/19 12:00 PM, Faiz Abbas wrote: >>> Adrian, >>> >>> On 25/02/19 1:47 PM, Adrian Hunter wrote: On 15/02/19 9:20 PM, Faiz Abbas wrote: > sdhci.c has two bottom halves

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-12 Thread Rizvi, Mohammad Faiz Abbas
Hi Adrian, On 3/8/2019 7:06 PM, Adrian Hunter wrote: > On 6/03/19 12:00 PM, Faiz Abbas wrote: >> Adrian, >> >> On 25/02/19 1:47 PM, Adrian Hunter wrote: >>> On 15/02/19 9:20 PM, Faiz Abbas wrote: sdhci.c has two bottom halves implemented. A threaded_irq for handling card insert/remove op

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-08 Thread Adrian Hunter
On 6/03/19 12:00 PM, Faiz Abbas wrote: > Adrian, > > On 25/02/19 1:47 PM, Adrian Hunter wrote: >> On 15/02/19 9:20 PM, Faiz Abbas wrote: >>> sdhci.c has two bottom halves implemented. A threaded_irq for handling >>> card insert/remove operations and a tasklet for finishing mmc requests. >>> With t

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-03-06 Thread Faiz Abbas
Adrian, On 25/02/19 1:47 PM, Adrian Hunter wrote: > On 15/02/19 9:20 PM, Faiz Abbas wrote: >> sdhci.c has two bottom halves implemented. A threaded_irq for handling >> card insert/remove operations and a tasklet for finishing mmc requests. >> With the addition of external dma support, dmaengine AP

Re: [PATCH v2 1/8] mmc: sdhci: Get rid of finish_tasklet

2019-02-25 Thread Adrian Hunter
On 15/02/19 9:20 PM, Faiz Abbas wrote: > sdhci.c has two bottom halves implemented. A threaded_irq for handling > card insert/remove operations and a tasklet for finishing mmc requests. > With the addition of external dma support, dmaengine APIs need to > terminate in non-atomic context before unma