Re: [PATCH v2 10/10] ARM: mstar: SMP support

2020-12-02 Thread Daniel Palmer
Hi Russell, On Wed, 2 Dec 2020 at 00:04, Russell King - ARM Linux admin wrote: > > On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > > + smpctrl = of_iomap(np, 0); > > + > > + if (!smpctrl) > > +

Re: [PATCH v2 10/10] ARM: mstar: SMP support

2020-12-01 Thread Russell King - ARM Linux admin
On Tue, Dec 01, 2020 at 10:43:30PM +0900, Daniel Palmer wrote: > + np = of_find_compatible_node(NULL, NULL, "mstar,smpctrl"); > + smpctrl = of_iomap(np, 0); > + > + if (!smpctrl) > + return -ENODEV; Wouldn't -ENOMEM be more appropriate here? -- RMK's Patch system: https://