Re: [PATCH v2 10/11] gpio: pca953x: Convert to use bitmap API

2019-10-23 Thread Geert Uytterhoeven
Hi Andy, On Wed, Oct 23, 2019 at 10:01 AM Andy Shevchenko wrote: > On Tue, Oct 22, 2019 at 08:03:00PM +0200, Geert Uytterhoeven wrote: > > On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko > > wrote: > > > Instead of customized approach convert the driver to use bitmap API. > > > > #define MAX_BA

Re: [PATCH v2 10/11] gpio: pca953x: Convert to use bitmap API

2019-10-23 Thread Andy Shevchenko
On Tue, Oct 22, 2019 at 08:03:00PM +0200, Geert Uytterhoeven wrote: > On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko > wrote: > > Instead of customized approach convert the driver to use bitmap API. > > #define MAX_BANK 5 > > #define BANK_SZ 8 > > +#define MAX_LINE (MAX_BANK * BANK_SZ) >

Re: [PATCH v2 10/11] gpio: pca953x: Convert to use bitmap API

2019-10-22 Thread Geert Uytterhoeven
Hi Andy, On Tue, Oct 22, 2019 at 7:29 PM Andy Shevchenko wrote: > Instead of customized approach convert the driver to use bitmap API. > > Depends-on: 6e9c6674d1bf ("gpio: pca953x: utilize the for_each_set_clump8 > macro") > Cc: William Breathitt Gray > Cc: Geert Uytterhoeven > Cc: Thomas Peta