Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-09-08 Thread peterz
On Wed, Sep 02, 2020 at 06:48:30AM -0700, Guenter Roeck wrote: > On 9/2/20 2:12 AM, pet...@infradead.org wrote: > > On Wed, Sep 02, 2020 at 11:09:35AM +0200, pet...@infradead.org wrote: > >> On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wrote: > >>> [0.00] WARNING: CPU: 0 PID: 0 a

Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-09-08 Thread Guenter Roeck
On 9/8/20 7:22 AM, pet...@infradead.org wrote: > On Wed, Sep 02, 2020 at 06:48:30AM -0700, Guenter Roeck wrote: >> On 9/2/20 2:12 AM, pet...@infradead.org wrote: >>> On Wed, Sep 02, 2020 at 11:09:35AM +0200, pet...@infradead.org wrote: On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wr

Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-09-02 Thread Guenter Roeck
On 9/2/20 2:12 AM, pet...@infradead.org wrote: > On Wed, Sep 02, 2020 at 11:09:35AM +0200, pet...@infradead.org wrote: >> On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wrote: >>> [0.00] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:4875 >>> check_flags.part.39+0x280/0x2a0 >>

Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-09-02 Thread peterz
On Wed, Sep 02, 2020 at 11:09:35AM +0200, pet...@infradead.org wrote: > On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wrote: > > [0.00] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:4875 > > check_flags.part.39+0x280/0x2a0 > > [0.00] DEBUG_LOCKS_WARN_ON(lockdep_hardi

Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-09-02 Thread peterz
On Tue, Sep 01, 2020 at 09:21:37PM -0700, Guenter Roeck wrote: > [0.00] WARNING: CPU: 0 PID: 0 at kernel/locking/lockdep.c:4875 > check_flags.part.39+0x280/0x2a0 > [0.00] DEBUG_LOCKS_WARN_ON(lockdep_hardirqs_enabled()) > [0.00] [<004cff18>] lock_acquire+0x218/0x4e0

Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-09-01 Thread Guenter Roeck
On Fri, Aug 21, 2020 at 10:47:48AM +0200, Peter Zijlstra wrote: > From: Nicholas Piggin > > Problem: > > raw_local_irq_save(); > local_irq_save(); > ... > local_irq_restore(); > raw_local_irq_restore(); > > existing instances: > > - lock_acquire() > raw_loca

Re: [PATCH v2 10/11] lockdep: Only trace IRQ edges

2020-08-25 Thread Thomas Gleixner
On Fri, Aug 21 2020 at 10:47, Peter Zijlstra wrote: > Now, given that the only reason to use the raw_* variant is because you don't > want tracing, A) seems like a weird option (although it can be done), so we > pick B) and declare any code that ends up doing: > > raw_local_irq_save() >