Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-24 Thread Finn Thain
On Fri, 24 Nov 2017, Greg Kroah-Hartman wrote: > > > > > > But what happens when the bus code is unloaded if it is built as a > > > module? The devices will be removed then. Or they should be. > > > > > > > This bus driver is not a module. > > It can not be built as a module ever? > That'

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-24 Thread Greg Kroah-Hartman
On Fri, Nov 24, 2017 at 10:40:20AM +1100, Finn Thain wrote: > On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > > > On Thu, Nov 23, 2017 at 11:24:38AM +1100, Finn Thain wrote: > > > On Mon, 20 Nov 2017, I wrote: > > > > > > > > You need to free up the memory allocated, and I don't see that > > >

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-23 Thread Finn Thain
On Thu, 23 Nov 2017, Greg Kroah-Hartman wrote: > On Thu, Nov 23, 2017 at 11:24:38AM +1100, Finn Thain wrote: > > On Mon, 20 Nov 2017, I wrote: > > > > > > You need to free up the memory allocated, and I don't see that > > > > happening here ... The kernel should yell at you ... > > > > > > > >

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-23 Thread Greg Kroah-Hartman
On Thu, Nov 23, 2017 at 11:24:38AM +1100, Finn Thain wrote: > On Mon, 20 Nov 2017, I wrote: > > > > You need to free up the memory allocated, and I don't see that > > > happening here ... The kernel should yell at you ... > > > > > WARN(1, KERN_ERR "Device '%s' does not have a r

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-22 Thread Finn Thain
On Mon, 20 Nov 2017, I wrote: > > You need to free up the memory allocated, and I don't see that > > happening here ... The kernel should yell at you ... > > WARN(1, KERN_ERR "Device '%s' does not have a release() " > "function, it is broken and must be f

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-19 Thread Finn Thain
On Sat, 18 Nov 2017, Greg Kroah-Hartman wrote: > On Fri, Nov 17, 2017 at 09:30:11PM -0500, Finn Thain wrote: > > This patch brings basic support for the Linux Driver Model to the > > NuBus subsystem. > > > > For flexibility, bus matching is left up to the drivers. This is also > > the approach ta

Re: [PATCH v2 13/13] nubus: Add support for the driver model

2017-11-18 Thread Greg Kroah-Hartman
On Fri, Nov 17, 2017 at 09:30:11PM -0500, Finn Thain wrote: > This patch brings basic support for the Linux Driver Model to the > NuBus subsystem. > > For flexibility, bus matching is left up to the drivers. This is also > the approach taken by NetBSD NuBus drivers in matching cards. > > Since a