Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread Greg KH
On Wed, Jun 17, 2020 at 07:32:44AM -0600, jim.cro...@gmail.com wrote: > hi Petr > > > You made to do some research and I was wrong. For example, getopt() > > operates with options and their arguments. So, 'keyword' and 'arg' names > > look good after all. > > > > Well, I still think that only one

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread jim . cromie
hi Petr > You made to do some research and I was wrong. For example, getopt() > operates with options and their arguments. So, 'keyword' and 'arg' names > look good after all. > > Well, I still think that only one syntax should be supported. And it > is better to distinguish keywords and arguments

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-17 Thread Petr Mladek
On Tue 2020-06-16 14:08:57, jim.cro...@gmail.com wrote: > On Tue, Jun 16, 2020 at 5:57 AM Petr Mladek wrote: > > > > On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > > > Current code expects "keyword" "arg" as 2 space separated words. > > > Change to also accept "keyword:arg" and "keyword=arg" form

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-16 Thread jim . cromie
On Tue, Jun 16, 2020 at 5:57 AM Petr Mladek wrote: > > On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > > Current code expects "keyword" "arg" as 2 space separated words. > > Change to also accept "keyword:arg" and "keyword=arg" forms as well, > > and drop !(nwords%2) requirement. > > > > Then in r

Re: [PATCH v2 19/24] dyndbg: accept query terms like module:foo and file=bar

2020-06-16 Thread Petr Mladek
On Sat 2020-06-13 09:57:33, Jim Cromie wrote: > Current code expects "keyword" "arg" as 2 space separated words. > Change to also accept "keyword:arg" and "keyword=arg" forms as well, > and drop !(nwords%2) requirement. > > Then in rest of function, use new keyword,arg variables instead of > word[