Re: [PATCH v2 2/2] i2c: New bus driver for the QUP I2C controller

2014-01-16 Thread Ivan T. Ivanov
Hi, On Wed, 2014-01-15 at 08:46 -0800, Stephen Boyd wrote: > On 01/13, Bjorn Andersson wrote: > > +/* > > + * QUP driver for Qualcomm MSM platforms > > + * > > + */ > > This comment seems redundant, we know what file we're looking at. > > > + > > +struct qup_i2c_dev { > > + struct device

Re: [PATCH v2 2/2] i2c: New bus driver for the QUP I2C controller

2014-01-15 Thread Stephen Boyd
On 01/13, Bjorn Andersson wrote: > +/* > + * QUP driver for Qualcomm MSM platforms > + * > + */ This comment seems redundant, we know what file we're looking at. > + > +struct qup_i2c_dev { > + struct device *dev; > + void __iomem*base; > + struct pinctrl

Re: [PATCH v2 2/2] i2c: New bus driver for the QUP I2C controller

2014-01-14 Thread Ivan T. Ivanov
Hi Bjorn, Just two comments. On Mon, 2014-01-13 at 16:30 -0800, Bjorn Andersson wrote: > From: "Ivan T. Ivanov" > > This bus driver supports the QUP i2c hardware controller in the Qualcomm > MSM SOCs. The Qualcomm Universal Peripheral Engine (QUP) is a general > purpose data path engine wit