Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-19 Thread Dirk Brandewie
On 03/18/2014 10:20 PM, Viresh Kumar wrote: On 19 March 2014 01:14, Dirk Brandewie wrote: There was no problem per se. In stop() all I really needed to do is stop the timer and set the P state to MIN. At init time I need to allocate memory and start timer. If stopping the timer and deallocat

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-18 Thread Viresh Kumar
On 19 March 2014 01:14, Dirk Brandewie wrote: > There was no problem per se. In stop() all I really needed to do is stop > the > timer and set the P state to MIN. > > At init time I need to allocate memory and start timer. If stopping the > timer > and deallocating memory are separated then I ne

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-18 Thread Srivatsa S. Bhat
On 03/19/2014 01:14 AM, Dirk Brandewie wrote: > On 03/18/2014 11:52 AM, Srivatsa S. Bhat wrote: >> On 03/18/2014 08:31 PM, Dirk Brandewie wrote: >>> On 03/17/2014 10:44 PM, Viresh Kumar wrote: On Sat, Mar 15, 2014 at 2:33 AM, wrote: > + >static int intel_pstate_cpu_init(struct cp

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-18 Thread Dirk Brandewie
On 03/18/2014 11:52 AM, Srivatsa S. Bhat wrote: On 03/18/2014 08:31 PM, Dirk Brandewie wrote: On 03/17/2014 10:44 PM, Viresh Kumar wrote: On Sat, Mar 15, 2014 at 2:33 AM, wrote: + static int intel_pstate_cpu_init(struct cpufreq_policy *policy) { struct cpudata *cpu; @@ -818,7

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-18 Thread Srivatsa S. Bhat
On 03/18/2014 08:31 PM, Dirk Brandewie wrote: > On 03/17/2014 10:44 PM, Viresh Kumar wrote: >> On Sat, Mar 15, 2014 at 2:33 AM, wrote: >>> + >>> static int intel_pstate_cpu_init(struct cpufreq_policy *policy) >>> { >>> struct cpudata *cpu; >>> @@ -818,7 +824,7 @@ static struct cpufre

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-18 Thread Dirk Brandewie
On 03/17/2014 10:44 PM, Viresh Kumar wrote: On Sat, Mar 15, 2014 at 2:33 AM, wrote: + static int intel_pstate_cpu_init(struct cpufreq_policy *policy) { struct cpudata *cpu; @@ -818,7 +824,7 @@ static struct cpufreq_driver intel_pstate_driver = { .setpolicy = intel_ps

Re: [PATCH v2 2/2] intel_pstate: Set core to min P state during core offline

2014-03-17 Thread Viresh Kumar
On Sat, Mar 15, 2014 at 2:33 AM, wrote: > From: Dirk Brandewie > > Change to use ->stop() callback to do clean up during CPU > hotplug. The requested P state for an offline core will be used by the > hardware coordination function to select the package P state. If the > core is under load when i