Re: [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock

2019-05-07 Thread Josh Poimboeuf
On Tue, May 07, 2019 at 01:50:29PM +0200, Petr Mladek wrote: > On Mon 2019-05-06 19:43:19, Josh Poimboeuf wrote: > > On Tue, Apr 30, 2019 at 11:10:49AM +0200, Petr Mladek wrote: > > > klp_try_switch_task() is called under klp_mutex. The buffer for > > > debugging messages might be static. > > > >

Re: [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock

2019-05-07 Thread Petr Mladek
On Mon 2019-05-06 19:43:19, Josh Poimboeuf wrote: > On Tue, Apr 30, 2019 at 11:10:49AM +0200, Petr Mladek wrote: > > klp_try_switch_task() is called under klp_mutex. The buffer for > > debugging messages might be static. > > The patch description is missing a "why" (presumably to reduce stack > us

Re: [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock

2019-05-06 Thread Josh Poimboeuf
On Tue, Apr 30, 2019 at 11:10:49AM +0200, Petr Mladek wrote: > klp_try_switch_task() is called under klp_mutex. The buffer for > debugging messages might be static. The patch description is missing a "why" (presumably to reduce stack usage). > > Signed-off-by: Petr Mladek > --- > kernel/livepa

Re: [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock

2019-04-30 Thread Kamalesh Babulal
On Tue, Apr 30, 2019 at 11:10:49AM +0200, Petr Mladek wrote: > klp_try_switch_task() is called under klp_mutex. The buffer for > debugging messages might be static. > > Signed-off-by: Petr Mladek Reviewed-by: Kamalesh Babulal

Re: [PATCH v2 2/2] livepatch: Use static buffer for debugging messages under rq lock

2019-04-30 Thread Miroslav Benes
On Tue, 30 Apr 2019, Petr Mladek wrote: > klp_try_switch_task() is called under klp_mutex. The buffer for > debugging messages might be static. > > Signed-off-by: Petr Mladek Acked-by: Miroslav Benes Miroslav