Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check

2017-08-08 Thread Thomas Garnier
On Mon, Aug 7, 2017 at 10:55 AM, Russell King - ARM Linux wrote: > > It's better in so far as it avoids the problems previously highlighted. > > However, it depends how efficient we want these paths to be - the > difference between your assembly and the assembly I've previously > supplied is that

Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check

2017-08-07 Thread Russell King - ARM Linux
On Mon, Aug 07, 2017 at 10:42:14AM -0700, Thomas Garnier wrote: > On Mon, Aug 7, 2017 at 10:35 AM, Kees Cook wrote: > > On Wed, Jul 26, 2017 at 10:00 AM, Thomas Garnier > > wrote: > >> Disable the generic address limit check in favor of an architecture > >> specific optimized implementation. The

Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check

2017-08-07 Thread Thomas Garnier
On Mon, Aug 7, 2017 at 10:35 AM, Kees Cook wrote: > On Wed, Jul 26, 2017 at 10:00 AM, Thomas Garnier wrote: >> Disable the generic address limit check in favor of an architecture >> specific optimized implementation. The generic implementation using >> pending work flags did not work well with AR

Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check

2017-08-07 Thread Kees Cook
On Wed, Jul 26, 2017 at 10:00 AM, Thomas Garnier wrote: > Disable the generic address limit check in favor of an architecture > specific optimized implementation. The generic implementation using > pending work flags did not work well with ARM and alignment faults. > > The address limit is checked

Re: [PATCH v2 2/3] arm/syscalls: Optimize address limit check

2017-08-02 Thread Thomas Garnier
On Wed, Jul 26, 2017 at 10:00 AM, Thomas Garnier wrote: > Disable the generic address limit check in favor of an architecture > specific optimized implementation. The generic implementation using > pending work flags did not work well with ARM and alignment faults. > > The address limit is checked