Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-19 Thread Jan Kiszka
On 2017-01-18 13:46, Mark Brown wrote: > On Wed, Jan 18, 2017 at 10:33:07AM +0100, Jan Kiszka wrote: >> On 2017-01-18 09:21, Robert Jarzmik wrote: > >> +while (1) { > > This bit worries me a bit, as this can be either : > - hogging the SoC's CPU, endlessly running > - or

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-18 Thread Mark Brown
On Wed, Jan 18, 2017 at 10:33:07AM +0100, Jan Kiszka wrote: > On 2017-01-18 09:21, Robert Jarzmik wrote: > +while (1) { > >>> This bit worries me a bit, as this can be either : > >>> - hogging the SoC's CPU, endlessly running > >>> - or even worse, blocking the CPU for ever > >>>

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-18 Thread Jan Kiszka
On 2017-01-18 09:21, Robert Jarzmik wrote: > Jan Kiszka writes: > >> On 2017-01-17 08:54, Robert Jarzmik wrote: >>> Jan Kiszka writes: >>> When using the a device with edge-triggered interrupts, such as MSIs, the interrupt handler has to ensure that there is a point in time during

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-18 Thread Robert Jarzmik
Jan Kiszka writes: > On 2017-01-17 08:54, Robert Jarzmik wrote: >> Jan Kiszka writes: >> >>> When using the a device with edge-triggered interrupts, such as MSIs, >>> the interrupt handler has to ensure that there is a point in time during >>> its execution where all interrupts sources are sile

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-17 Thread Jan Kiszka
On 2017-01-16 20:46, Jan Kiszka wrote: > On 2017-01-16 20:07, Andy Shevchenko wrote: >> On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote: >>> When using the a device with edge-triggered interrupts, such as MSIs, >>> the interrupt handler has to ensure that there is a point in time >>> during >>>

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-17 Thread Jan Kiszka
On 2017-01-17 14:11, Jarkko Nikula wrote: > On 01/17/2017 10:10 AM, Jan Kiszka wrote: >> On 2017-01-17 08:58, Robert Jarzmik wrote: >>> Jan Kiszka writes: >>> When using the a device with edge-triggered interrupts, such as MSIs, the interrupt handler has to ensure that there is a point i

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-17 Thread Jarkko Nikula
On 01/17/2017 10:10 AM, Jan Kiszka wrote: On 2017-01-17 08:58, Robert Jarzmik wrote: Jan Kiszka writes: When using the a device with edge-triggered interrupts, such as MSIs, the interrupt handler has to ensure that there is a point in time during its execution where all interrupts sources are

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-17 Thread Jan Kiszka
On 2017-01-17 08:58, Robert Jarzmik wrote: > Jan Kiszka writes: > >> When using the a device with edge-triggered interrupts, such as MSIs, >> the interrupt handler has to ensure that there is a point in time during >> its execution where all interrupts sources are silent so that a new >> event ca

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-17 Thread Jan Kiszka
On 2017-01-17 08:54, Robert Jarzmik wrote: > Jan Kiszka writes: > >> When using the a device with edge-triggered interrupts, such as MSIs, >> the interrupt handler has to ensure that there is a point in time during >> its execution where all interrupts sources are silent so that a new >> event ca

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-17 Thread Robert Jarzmik
Jan Kiszka writes: > When using the a device with edge-triggered interrupts, such as MSIs, > the interrupt handler has to ensure that there is a point in time during > its execution where all interrupts sources are silent so that a new > event can trigger a new interrupt again. > > This is achiev

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-16 Thread Robert Jarzmik
Jan Kiszka writes: > When using the a device with edge-triggered interrupts, such as MSIs, > the interrupt handler has to ensure that there is a point in time during > its execution where all interrupts sources are silent so that a new > event can trigger a new interrupt again. > > This is achiev

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-16 Thread Jan Kiszka
On 2017-01-16 20:07, Andy Shevchenko wrote: > On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote: >> When using the a device with edge-triggered interrupts, such as MSIs, >> the interrupt handler has to ensure that there is a point in time >> during >> its execution where all interrupts sources ar

Re: [PATCH v2 2/3] spi: pxa2xx: Prepare for edge-triggered interrupts

2017-01-16 Thread Andy Shevchenko
On Mon, 2017-01-16 at 19:44 +0100, Jan Kiszka wrote: > When using the a device with edge-triggered interrupts, such as MSIs, > the interrupt handler has to ensure that there is a point in time > during > its execution where all interrupts sources are silent so that a new > event can trigger a new i