Re: [PATCH v2 2/4] edac: Add support for Amazon's Annapurna Labs L1 EDAC

2019-07-09 Thread Joe Perches
On Tue, 2019-07-09 at 17:32 +0800, Jonathan Cameron wrote: > On Sun, 7 Jul 2019 14:57:36 +0300 [] > > +#define ARM_CA57_CPUMERRSR_REPEAT GENMASK(39, 32) > > +#define ARM_CA57_CPUMERRSR_OTHER GENMASK(47, 40) > > +#define ARM_CA57_CPUMERRSR_FATAL GENMASK(63, 63) GENMASK_

Re: [PATCH v2 2/4] edac: Add support for Amazon's Annapurna Labs L1 EDAC

2019-07-09 Thread Jonathan Cameron
On Tue, 9 Jul 2019 14:01:03 +0300 "Hawa, Hanna" wrote: > On 7/9/2019 12:32 PM, Jonathan Cameron wrote: > >> Signed-off-by: Hanna Hawa > > A quick drive by review as I was feeling curious. > > > > Just a couple of trivial queries and observation on the fact it > > might be useful to add a few d

Re: [PATCH v2 2/4] edac: Add support for Amazon's Annapurna Labs L1 EDAC

2019-07-09 Thread Hawa, Hanna
On 7/9/2019 12:32 PM, Jonathan Cameron wrote: Signed-off-by: Hanna Hawa A quick drive by review as I was feeling curious. Just a couple of trivial queries and observation on the fact it might be useful to add a few devm managed functions to cut down on edac driver boilerplate. Thanks, Jona

Re: [PATCH v2 2/4] edac: Add support for Amazon's Annapurna Labs L1 EDAC

2019-07-09 Thread Jonathan Cameron
On Sun, 7 Jul 2019 14:57:36 +0300 Hanna Hawa wrote: > Adds support for Amazon's Annapurna Labs L1 EDAC driver to detect and > report L1 errors. > > Signed-off-by: Hanna Hawa A quick drive by review as I was feeling curious. Just a couple of trivial queries and observation on the fact it might