On 3/1/19 2:51 AM, Andrey Ryabinin wrote:
>
>
> On 3/1/19 12:44 AM, John Hubbard wrote:
>> On 2/28/19 12:33 AM, Andrey Ryabinin wrote:
>>> We have common pattern to access lru_lock from a page pointer:
>>> zone_lru_lock(page_zone(page))
>>>
>>> Which is silly, because it unfolds to this:
>>>
On 3/1/19 12:44 AM, John Hubbard wrote:
> On 2/28/19 12:33 AM, Andrey Ryabinin wrote:
>> We have common pattern to access lru_lock from a page pointer:
>> zone_lru_lock(page_zone(page))
>>
>> Which is silly, because it unfolds to this:
>>
>> &NODE_DATA(page_to_nid(page))->node_zones[p
On 2/28/19 1:56 PM, Vlastimil Babka wrote:
> On 2/28/2019 10:44 PM, John Hubbard wrote:
>> Instead of removing that function, let's change it, and add another
>> (since you have two cases: either a page* or a pgdat* is available),
>> and move it to where it can compile, like this:
>>
>>
>> diff --g
On 2/28/2019 10:44 PM, John Hubbard wrote:
> Instead of removing that function, let's change it, and add another
> (since you have two cases: either a page* or a pgdat* is available),
> and move it to where it can compile, like this:
>
>
> diff --git a/include/linux/mm.h b/include/linux/mm.h
> in
On 2/28/19 12:33 AM, Andrey Ryabinin wrote:
> We have common pattern to access lru_lock from a page pointer:
> zone_lru_lock(page_zone(page))
>
> Which is silly, because it unfolds to this:
>
> &NODE_DATA(page_to_nid(page))->node_zones[page_zonenum(page)]->zone_pgdat->lru_lock
> while
> On Feb 28, 2019, at 11:22 AM, Andrew Morton wrote:
>
> I don't think so. This kernedoc comment was missing its leading /**.
> The patch fixes that.
That makes sense; it had looked like just an extraneous asterisk.
On Thu, 28 Feb 2019 05:53:37 -0700 William Kucharski
wrote:
> > On Feb 28, 2019, at 1:33 AM, Andrey Ryabinin
> > wrote:
>
> > diff --git a/mm/vmscan.c b/mm/vmscan.c
> > index a9852ed7b97f..2d081a32c6a8 100644
> > --- a/mm/vmscan.c
> > +++ b/mm/vmscan.c
> > @@ -1614,8 +1614,8 @@ static __alway
> On Feb 28, 2019, at 1:33 AM, Andrey Ryabinin wrote:
> diff --git a/mm/vmscan.c b/mm/vmscan.c
> index a9852ed7b97f..2d081a32c6a8 100644
> --- a/mm/vmscan.c
> +++ b/mm/vmscan.c
> @@ -1614,8 +1614,8 @@ static __always_inline void update_lru_sizes(struct
> lruvec *lruvec,
>
> }
>
> -/*
> - *
On Thu, Feb 28, 2019 at 11:33:27AM +0300, Andrey Ryabinin wrote:
> We have common pattern to access lru_lock from a page pointer:
> zone_lru_lock(page_zone(page))
>
> Which is silly, because it unfolds to this:
>
> &NODE_DATA(page_to_nid(page))->node_zones[page_zonenum(page)]->zone_pg
9 matches
Mail list logo
