Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

2016-06-06 Thread Hanjun Guo
Hi Leizhen, On 2016/6/6 9:24, Leizhen (ThunderTown) wrote: On 2016/6/3 17:45, Will Deacon wrote: On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: On 2016/6/2 4:13, Rob Herring wrote: I believe you still need this and not the one above. You only need it within the loop

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

2016-06-05 Thread Leizhen (ThunderTown)
On 2016/6/3 17:45, Will Deacon wrote: > On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: >> On 2016/6/2 4:13, Rob Herring wrote: >>> I believe you still need this and not the one above. You only need it >>> within the loop if you return. Otherwise, the last node always need

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

2016-06-03 Thread Will Deacon
On Fri, Jun 03, 2016 at 10:45:20AM +0100, Will Deacon wrote: > On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: > > On 2016/6/2 4:13, Rob Herring wrote: > > > I believe you still need this and not the one above. You only need it > > > within the loop if you return. Otherwise,

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

2016-06-03 Thread Will Deacon
On Thu, Jun 02, 2016 at 09:36:40AM +0800, Leizhen (ThunderTown) wrote: > On 2016/6/2 4:13, Rob Herring wrote: > > I believe you still need this and not the one above. You only need it > > within the loop if you return. Otherwise, the last node always need to > > be put. > > OK. Thanks. > > Additi

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

2016-06-01 Thread Leizhen (ThunderTown)
On 2016/6/2 4:13, Rob Herring wrote: > On Sat, May 28, 2016 at 4:22 AM, Zhen Lei wrote: >> For a normal memory@ devicetree node, its reg property can contains more >> memory blocks. >> >> Because we don't known how many memory blocks maybe contained, so we try >> from index=0, increase 1 until e

Re: [PATCH v2 2/5] of/numa: fix a memory@ node can only contains one memory block

2016-06-01 Thread Rob Herring
On Sat, May 28, 2016 at 4:22 AM, Zhen Lei wrote: > For a normal memory@ devicetree node, its reg property can contains more > memory blocks. > > Because we don't known how many memory blocks maybe contained, so we try > from index=0, increase 1 until error returned(the end). > > Signed-off-by: Zhe