Re: [PATCH v2 2/8] watchdog: Introduce hardware maximum timeout in watchdog core

2015-08-15 Thread Guenter Roeck
On 08/14/2015 04:23 AM, Uwe Kleine-König wrote: Hello Guenter, On Fri, Aug 07, 2015 at 10:02:41PM -0700, Guenter Roeck wrote: [...] @@ -61,26 +135,27 @@ static struct watchdog_device *old_wdd; static int watchdog_ping(struct watchdog_device *wdd) { - int err = 0; + int err;

Re: [PATCH v2 2/8] watchdog: Introduce hardware maximum timeout in watchdog core

2015-08-15 Thread Guenter Roeck
Hi Uwe, On 08/13/2015 02:13 PM, Uwe Kleine-König wrote: Hello Guenter, On Fri, Aug 07, 2015 at 10:02:41PM -0700, Guenter Roeck wrote: Introduce an optional hardware maximum timeout in the watchdog core. The hardware maximum timeout can be lower than the maximum timeout. Drivers can set the ma

Re: [PATCH v2 2/8] watchdog: Introduce hardware maximum timeout in watchdog core

2015-08-14 Thread Uwe Kleine-König
Hello Guenter, On Fri, Aug 07, 2015 at 10:02:41PM -0700, Guenter Roeck wrote: > [...] > @@ -61,26 +135,27 @@ static struct watchdog_device *old_wdd; > > static int watchdog_ping(struct watchdog_device *wdd) > { > - int err = 0; > + int err; > > mutex_lock(&wdd->lock); > + e

Re: [PATCH v2 2/8] watchdog: Introduce hardware maximum timeout in watchdog core

2015-08-13 Thread Uwe Kleine-König
Hello Guenter, On Fri, Aug 07, 2015 at 10:02:41PM -0700, Guenter Roeck wrote: > Introduce an optional hardware maximum timeout in the watchdog core. > The hardware maximum timeout can be lower than the maximum timeout. > > Drivers can set the maximum hardware timeout value in the watchdog data >