Re: [PATCH v2 20/20] HID: multitouch: Remove the redundant touch state

2012-08-30 Thread Henrik Rydberg
> - After a little bit a playing with some surfaces, I can confuse the > input_mt_assign_slot_by_id function: for the very same contact id, I > got up to four different slots This accumulates the clicks and is > not very good :-( Reading again, the input-mt match-by-id code does not do any

Re: [PATCH v2 20/20] HID: multitouch: Remove the redundant touch state

2012-08-29 Thread Henrik Rydberg
> - I don't know if it is my configuration or not, but I'm receiving at > each frame (between two EV_SYN) all ABS_MT_SLOT events, even when > there are not used. Your configuration is fine, I screwed up. Will fix. > - After a little bit a playing with some surfaces, I can confuse the > input_mt_a

Re: [PATCH v2 20/20] HID: multitouch: Remove the redundant touch state

2012-08-29 Thread Benjamin Tissoires
Hi Henrik, Thanks for the new version. I still didn't review in depth the patch (it seemed to be fair). However, I found out 2 bugs while testing it (related to the whole series apparently): - I don't know if it is my configuration or not, but I'm receiving at each frame (between two EV_SYN) all