Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-21 Thread Hector Martin
On 21/02/2021 23.59, Marc Zyngier wrote: Here's what I've been using last time I had to muck with the 4210 stuff: qemu-system-arm \ -kernel arch/arm/boot/zImage -M smdkc210 \ -append "console=ttySAC0,115200n8 earlycon=smh root=/dev/mmcblk0p2 rootwait" \ -nographic -semi

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-21 Thread Marc Zyngier
On Sun, 21 Feb 2021 14:38:16 +, Hector Martin wrote: > > On 21/02/2021 04.17, Marc Zyngier wrote: > > On 2021-02-20 19:13, Krzysztof Kozlowski wrote: > >> On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > >>> On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > > Also fix a bu

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-21 Thread Hector Martin
On 21/02/2021 04.17, Marc Zyngier wrote: On 2021-02-20 19:13, Krzysztof Kozlowski wrote: On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: On 16/02/2021 03.51, Krzysztof Kozlowski wrote: Also fix a bug checking the return value, which should use IS_ERR(). No, no, no. We never, n

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-20 Thread Marc Zyngier
On 2021-02-20 19:13, Krzysztof Kozlowski wrote: On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > > Also fix a bug checking the return value, which should use IS_ERR(). > > No, no, no. We never, never combine fixing bugs with some re

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-20 Thread Krzysztof Kozlowski
On Thu, Feb 18, 2021 at 11:01:21PM +0900, Hector Martin wrote: > On 16/02/2021 03.51, Krzysztof Kozlowski wrote: > > > Also fix a bug checking the return value, which should use IS_ERR(). > > > > No, no, no. We never, never combine fixing bugs with some rework. > > However devm_ioremap() returns N

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-18 Thread Hector Martin
On 16/02/2021 03.51, Krzysztof Kozlowski wrote: Also fix a bug checking the return value, which should use IS_ERR(). No, no, no. We never, never combine fixing bugs with some rework. However devm_ioremap() returns NULL so where is the error? Sorry, this was a commit message mistake. The code

Re: [PATCH v2 20/25] tty: serial: samsung_tty: Use devm_ioremap_resource

2021-02-15 Thread Krzysztof Kozlowski
On Mon, Feb 15, 2021 at 09:17:08PM +0900, Hector Martin wrote: > This picks up the non-posted I/O mode needed for Apple platforms to > work properly. > > This removes the request/release functions, which are no longer > necessary, since devm_ioremap_resource takes care of that already. Most > othe