Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On 2 January 2018 at 14:53, Geert Uytterhoeven wrote: > On Tue, Jan 2, 2018 at 1:53 PM, Ulf Hansson wrote: >> On 2 January 2018 at 11:48, Rafael J. Wysocki wrote: >>> On Tue, Jan 2, 2018 at 11:44 AM, Geert Uytterhoeven >>> wrote: On Tue, Jan 2, 2018 at 11:32 AM, Rafael J. Wysocki wr

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

Hi Ulf, On Tue, Jan 2, 2018 at 2:02 PM, Ulf Hansson wrote: Signed-off-by: Geert Uytterhoeven [Ulf: Converted to use the WAKEUP_PATH driver PM flag] >> >> Ulf: + killing the DEV_PM_OPS define, increasing kernel size if PM_SUSPEND=n? > > Oh, yes - correct! > > The code looks nicer, with

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On Tue, Jan 2, 2018 at 1:53 PM, Ulf Hansson wrote: > On 2 January 2018 at 11:48, Rafael J. Wysocki wrote: >> On Tue, Jan 2, 2018 at 11:44 AM, Geert Uytterhoeven >> wrote: >>> On Tue, Jan 2, 2018 at 11:32 AM, Rafael J. Wysocki >>> wrote: On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

>>> Signed-off-by: Geert Uytterhoeven >>> [Ulf: Converted to use the WAKEUP_PATH driver PM flag] > > Ulf: + killing the DEV_PM_OPS define, increasing kernel size if PM_SUSPEND=n? Oh, yes - correct! The code looks nicer, with the penalty of one static struct declared and not used, in case CONFIG_

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On 2 January 2018 at 11:48, Rafael J. Wysocki wrote: > On Tue, Jan 2, 2018 at 11:44 AM, Geert Uytterhoeven > wrote: >> Hi Rafael, >> >> On Tue, Jan 2, 2018 at 11:32 AM, Rafael J. Wysocki wrote: >>> On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: From: Geert Uytterhoeven Sinc

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On Tue, Jan 2, 2018 at 11:44 AM, Geert Uytterhoeven wrote: > Hi Rafael, > > On Tue, Jan 2, 2018 at 11:32 AM, Rafael J. Wysocki wrote: >> On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: >>> From: Geert Uytterhoeven >>> >>> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disa

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

Hi Rafael, On Tue, Jan 2, 2018 at 11:32 AM, Rafael J. Wysocki wrote: > On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: >> From: Geert Uytterhoeven >> >> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable >> when wake-up is enabled"), when a GPIO is used for wakeup, the

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: > From: Geert Uytterhoeven > > Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable > when wake-up is enabled"), when a GPIO is used for wakeup, the GPIO block's > module clock (if exists) is manually kept running during syst

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On Tue, Jan 2, 2018 at 10:37 AM, Geert Uytterhoeven wrote: > Hi Linus, > > On Tue, Jan 2, 2018 at 10:27 AM, Linus Walleij > wrote: >> On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: >>> From: Geert Uytterhoeven >>> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable >>

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

Hi Linus, On Tue, Jan 2, 2018 at 10:27 AM, Linus Walleij wrote: > On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: >> From: Geert Uytterhoeven >> Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable >> when wake-up is enabled"), when a GPIO is used for wakeup, the GPIO bl

Re: [PATCH v2 3/3] gpio: rcar: Use WAKEUP_PATH driver PM flag

On Fri, Dec 29, 2017 at 2:31 PM, Ulf Hansson wrote: > From: Geert Uytterhoeven > > Since commit ab82fa7da4dce5c7 ("gpio: rcar: Prevent module clock disable > when wake-up is enabled"), when a GPIO is used for wakeup, the GPIO block's > module clock (if exists) is manually kept running during sys