Re: [PATCH v2 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver

2019-01-21 Thread Dan O'Donovan
Hi Linus Many thanks for your feedback below, and sorry that I'm only getting to follow up on this now.  I've added some initial responses inline below. On 10/22/18 10:07 AM, Linus Walleij wrote: > On Fri, Oct 19, 2018 at 7:16 PM Dan O'Donovan wrote: > >> From: Javier Arteaga >> >> The UP2 boa

Re: [PATCH v2 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver

2018-10-31 Thread Dan O'Donovan
Thanks for your review feedback, Andy!  I'll send a v3 shortly with those changes you suggested.  I've added some comments inline below. On 10/20/2018 12:40 PM, Andy Shevchenko wrote: > On Fri, Oct 19, 2018 at 8:24 PM Dan O'Donovan wrote: > >> +static int upboard_get_functions_count(struct pinct

Re: [PATCH v2 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver

2018-10-22 Thread Linus Walleij
On Fri, Oct 19, 2018 at 7:16 PM Dan O'Donovan wrote: > From: Javier Arteaga > > The UP2 board features a Raspberry Pi compatible pin header (HAT) and a > board-specific expansion connector (EXHAT). Which makes me want to have Eric Anholt's review on this patch so as to secure basic interoperabi

Re: [PATCH v2 3/3] pinctrl: upboard: Add UP2 pinctrl and gpio driver

2018-10-20 Thread Andy Shevchenko
On Fri, Oct 19, 2018 at 8:24 PM Dan O'Donovan wrote: > > From: Javier Arteaga > > The UP2 board features a Raspberry Pi compatible pin header (HAT) and a > board-specific expansion connector (EXHAT). Both expose assorted > functions from either the SoC (such as GPIO, I2C, SPI, UART...) or other >