Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support

2017-04-10 Thread Juergen Borleis
Hi Andrew, On Friday 07 April 2017 15:40:07 Andrew Lunn wrote: > > +Optional properties: > > + > > +- reset-gpios: GPIO to be used to reset the whole device, always low > > active > > I would avoid the always low active comment. The input to the switch > is active low. But i've seen designs with a

Re: [PATCH v2 3/4] net: dsa: LAN9303: add I2C managed mode support

2017-04-07 Thread Andrew Lunn
Hi Juergen > +Optional properties: > + > +- reset-gpios: GPIO to be used to reset the whole device, always low active I would avoid the always low active comment. The input to the switch is active low. But i've seen designs with an inverter in the reset path, so from the perspective of the GPIO i