Re: [PATCH v2 3/5] regulator: add bcm590xx regulator driver

2014-03-11 Thread Matt Porter
On Wed, Feb 19, 2014 at 01:52:32PM +0900, Mark Brown wrote: > On Tue, Feb 18, 2014 at 06:17:10PM -0500, Matt Porter wrote: > > > +static struct of_device_id bcm590xx_of_match[] = { > > + { .compatible = "brcm,bcm59056-regs", }, > > + { } > > +}; > > This looks pretty much OK however I am in g

Re: [PATCH v2 3/5] regulator: add bcm590xx regulator driver

2014-02-18 Thread Mark Brown
On Tue, Feb 18, 2014 at 06:17:10PM -0500, Matt Porter wrote: > +static struct of_device_id bcm590xx_of_match[] = { > + { .compatible = "brcm,bcm59056-regs", }, > + { } > +}; This looks pretty much OK however I am in general suspicious of MFDs that have subdevices like this in the DT - it