Re: [PATCH v2 3/6] spi: dw: Add Microchip Sparx5 support

2020-07-02 Thread Lars Povlsen
Mark Brown writes: > On Tue, Jun 23, 2020 at 03:53:22PM +0200, Lars Povlsen wrote: > > Mark Brown writes: > > > >If there's a mux that needs to be handled specially that mux should be > > >described in DT on the relevant boards, there shouldn't just be > > >something hard coded in the controlle

Re: [PATCH v2 3/6] spi: dw: Add Microchip Sparx5 support

2020-06-23 Thread Mark Brown
On Tue, Jun 23, 2020 at 03:53:22PM +0200, Lars Povlsen wrote: > Mark Brown writes: > >If there's a mux that needs to be handled specially that mux should be > >described in DT on the relevant boards, there shouldn't just be > >something hard coded in the controller driver. > I looked at the spi-m

Re: [PATCH v2 3/6] spi: dw: Add Microchip Sparx5 support

2020-06-23 Thread Lars Povlsen
Mark Brown writes: On Mon, Jun 22, 2020 at 12:46:33PM +0200, Lars Povlsen wrote: >> On Fri, Jun 19, 2020 at 01:31:18PM +0200, Lars Povlsen wrote: > >> >> + if (!nEnable) { >> >> + /* Ensure CS toggles, so start off all disabled */ >> >> + regmap_write(dwsmscc->syscon, SPARX5_FORC

Re: [PATCH v2 3/6] spi: dw: Add Microchip Sparx5 support

2020-06-22 Thread Lars Povlsen
Mark Brown writes: On Fri, Jun 19, 2020 at 01:31:18PM +0200, Lars Povlsen wrote: >> +/* >> + * The Designware SPI controller (referred to as master in the >> + * documentation) automatically deasserts chip select when the tx fifo >> + * is empty. The chip selects then needs to be driven by a CS