Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-11 Thread Yinghai Lu
On Wed, Jun 11, 2014 at 10:58 AM, Rob Herring wrote: > On 06/10/2014 03:52 PM, Tony Luck wrote: > I think I figured it out. The function > serial8250_find_port_for_earlycon is failing to match 'uart' console to > 'ttyS' console and transfer the options. It was also failing to create > an option st

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-11 Thread Tony Luck
On Wed, Jun 11, 2014 at 10:58 AM, Rob Herring wrote: > I think I figured it out. The function > serial8250_find_port_for_earlycon is failing to match 'uart' console to > 'ttyS' console and transfer the options. It was also failing to create > an option string when the baud rate is probed. Can you

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-11 Thread Rob Herring
On 06/10/2014 03:52 PM, Tony Luck wrote: > On Mon, Jun 9, 2014 at 4:18 PM, Rob Herring wrote: >> It should do auto detect of the baud-rate if it is not specified which >> for 8250 is just reading the baud-rate divider and calculating the >> baud-rate using the uart clock. It should just reprogram

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-10 Thread Rob Herring
On Tue, Jun 10, 2014 at 3:52 PM, Tony Luck wrote: > On Mon, Jun 9, 2014 at 4:18 PM, Rob Herring wrote: >> It should do auto detect of the baud-rate if it is not specified which >> for 8250 is just reading the baud-rate divider and calculating the >> baud-rate using the uart clock. It should just

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-10 Thread Tony Luck
On Mon, Jun 9, 2014 at 4:18 PM, Rob Herring wrote: > It should do auto detect of the baud-rate if it is not specified which > for 8250 is just reading the baud-rate divider and calculating the > baud-rate using the uart clock. It should just reprogram the divider > with the same divider value. I d

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-09 Thread Rob Herring
On Mon, Jun 9, 2014 at 5:35 PM, Tony Luck wrote: > On Mon, Jun 9, 2014 at 3:25 PM, Tony Luck wrote: >> Linus' tree (HEAD=963649d735c8) is spitting out all sorts of garbage >> on the serial console - as if the baud rate is being periodically set >> to something weird, and then back to 112500. I s

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-09 Thread Rob Herring
On Mon, Jun 9, 2014 at 5:25 PM, Tony Luck wrote: > On Sat, May 3, 2014 at 3:16 PM, Greg Kroah-Hartman > wrote: >>> > >> drivers/tty/serial/8250/8250_early.c | 138 >>> > >> --- >>> > >> drivers/tty/serial/8250/Kconfig | 1 + >>> > >> 2 files changed, 16 in

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-09 Thread Tony Luck
On Mon, Jun 9, 2014 at 3:25 PM, Tony Luck wrote: > Linus' tree (HEAD=963649d735c8) is spitting out all sorts of garbage > on the serial console - as if the baud rate is being periodically set > to something weird, and then back to 112500. I see over a dozen > blocks of junk interspersed with good

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-06-09 Thread Tony Luck
On Sat, May 3, 2014 at 3:16 PM, Greg Kroah-Hartman wrote: >> > >> drivers/tty/serial/8250/8250_early.c | 138 >> > >> --- >> > >> drivers/tty/serial/8250/Kconfig | 1 + >> > >> 2 files changed, 16 insertions(+), 123 deletions(-) >> > > >> > > Hi Greg, Rob >

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-05-03 Thread Greg Kroah-Hartman
On Sat, May 03, 2014 at 06:07:31PM -0400, Greg Kroah-Hartman wrote: > On Mon, Apr 28, 2014 at 06:20:53PM -0500, Rob Herring wrote: > > On Sat, Apr 26, 2014 at 1:19 AM, Yinghai Lu wrote: > > > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring > > > wrote: > > >> From: Rob Herring > > >> > > >> With t

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-05-03 Thread Greg Kroah-Hartman
On Mon, Apr 28, 2014 at 06:20:53PM -0500, Rob Herring wrote: > On Sat, Apr 26, 2014 at 1:19 AM, Yinghai Lu wrote: > > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: > >> From: Rob Herring > >> > >> With the generic earlycon infrastructure in place, convert the 8250 > >> early console to use

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-29 Thread Yinghai Lu
On Tue, Apr 29, 2014 at 1:41 PM, Rob Herring wrote: > On Tue, Apr 29, 2014 at 1:22 PM, Yinghai Lu wrote: >> >> You want to obsolete "console=uart,io,0x3f8,115200n8" ? >> >> Let's check with Andrew. He suggested to use uart and uart8250 at that time. > > No, that is not what I'm saying. For the 2

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-29 Thread Rob Herring
On Tue, Apr 29, 2014 at 1:22 PM, Yinghai Lu wrote: > On Tue, Apr 29, 2014 at 8:16 AM, Rob Herring wrote: >> On Mon, Apr 28, 2014 at 9:56 PM, Yinghai Lu wrote: >>> On Mon, Apr 28, 2014 at 4:24 PM, Rob Herring wrote: On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: Thanks for fi

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-29 Thread Yinghai Lu
On Tue, Apr 29, 2014 at 8:16 AM, Rob Herring wrote: > On Mon, Apr 28, 2014 at 9:56 PM, Yinghai Lu wrote: >> On Mon, Apr 28, 2014 at 4:24 PM, Rob Herring wrote: >>> On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: >>> >>> Thanks for finding these. I missed them in my build tests. This should f

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-29 Thread Rob Herring
On Mon, Apr 28, 2014 at 9:56 PM, Yinghai Lu wrote: > On Mon, Apr 28, 2014 at 4:24 PM, Rob Herring wrote: >> On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: >> >> Thanks for finding these. I missed them in my build tests. This should fix >> them: >> >> diff --git a/drivers/tty/serial/8250/825

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-28 Thread Yinghai Lu
On Mon, Apr 28, 2014 at 4:24 PM, Rob Herring wrote: > On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: > > Thanks for finding these. I missed them in my build tests. This should fix > them: > > diff --git a/drivers/tty/serial/8250/8250_early.c > b/drivers/tty/serial/8250/8250_early.c > index e

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-28 Thread Rob Herring
On Sat, Apr 26, 2014 at 1:29 AM, Yinghai Lu wrote: > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: >> From: Rob Herring >> >> With the generic earlycon infrastructure in place, convert the 8250 >> early console to use it. >> >> Signed-off-by: Rob Herring >> Cc: Greg Kroah-Hartman >> Cc:

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-28 Thread Rob Herring
On Sat, Apr 26, 2014 at 1:19 AM, Yinghai Lu wrote: > On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: >> From: Rob Herring >> >> With the generic earlycon infrastructure in place, convert the 8250 >> early console to use it. >> >> Signed-off-by: Rob Herring >> Cc: Greg Kroah-Hartman >> Cc:

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-25 Thread Yinghai Lu
On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: > From: Rob Herring > > With the generic earlycon infrastructure in place, convert the 8250 > early console to use it. > > Signed-off-by: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > --- > drivers/tty/serial/8250/8250_early.c | 13

Re: [PATCH v2 3/7] tty/serial: convert 8250 to generic earlycon

2014-04-25 Thread Yinghai Lu
On Fri, Apr 18, 2014 at 3:19 PM, Rob Herring wrote: > From: Rob Herring > > With the generic earlycon infrastructure in place, convert the 8250 > early console to use it. > > Signed-off-by: Rob Herring > Cc: Greg Kroah-Hartman > Cc: Jiri Slaby > --- > drivers/tty/serial/8250/8250_early.c | 13