Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

2016-06-20 Thread Sebastian Reichel
Hi Helen, On Mon, Jun 20, 2016 at 04:06:10PM -0300, Helen Koike wrote: > I added these changes above and kept your tested-by and reviewed-by, could > you please confirm that I can keep them? As I changed more things then you > suggested. The changes look fine to me, the new patchset works on N900

Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

2016-06-20 Thread Helen Koike
On 20-06-2016 16:44, Lars-Peter Clausen wrote: + /* before widget power up */ + if (SND_SOC_DAPM_EVENT_ON(event)) { + /* Turn on the chip */ + tpa6130a2_power(data, true); + /* Sync the registers */ + ret = regcache_sync(data->

Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

2016-06-20 Thread Lars-Peter Clausen
> + /* before widget power up */ > + if (SND_SOC_DAPM_EVENT_ON(event)) { > + /* Turn on the chip */ > + tpa6130a2_power(data, true); > + /* Sync the registers */ > + ret = regcache_sync(data->regmap); > + if (ret < 0) { > +

Re: [PATCH v2 4/5] ASoC: tpa6130a2: Add DAPM support

2016-06-20 Thread Helen Koike
Hi Sebastian, Thank you for reviewing the patches. On 20-06-2016 14:12, Helen Koike wrote: Add DAPM support and updated rx51 accordingly. As a consequence: - the exported function tpa6130a2_stereo_enable is not needed anymore - the mutex is dealt in the DAPM - the power state is tracked by the