Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread Pierre Morel
On 22/08/2018 19:07, David Hildenbrand wrote: On 22.08.2018 18:51, Pierre Morel wrote: BUG: the crycbd must be tested for null even if not crossing a page boundary (which will never occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) No it was to

Re: [PATCH v2 4/5] KVM: s390: vsie: Always test the crycbd for NULL

2018-08-22 Thread David Hildenbrand
On 22.08.2018 18:51, Pierre Morel wrote: > BUG: the crycbd must be tested for null even if > not crossing a page boundary (which will never > occur in this case anyway). I don't see the BUG. Can you elaborate? (maybe it is too late for me) Either we return or we check for !crycb_addr > > Signed