Re: [PATCH v2 4/5] firmware: generalize reading file contents as a helper

2015-10-09 Thread Luis R. Rodriguez
On Fri, Oct 09, 2015 at 08:46:42AM -0400, Josh Boyer wrote: > On Thu, Oct 8, 2015 at 6:54 PM, Luis R. Rodriguez wrote: > > On Thu, Oct 08, 2015 at 01:36:53PM -0400, Josh Boyer wrote: > >> On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez > >> wrote: > >> > From: David Howells > >> > > >> > We'll

Re: [PATCH v2 4/5] firmware: generalize reading file contents as a helper

2015-10-09 Thread Josh Boyer
On Thu, Oct 8, 2015 at 6:54 PM, Luis R. Rodriguez wrote: > On Thu, Oct 08, 2015 at 01:36:53PM -0400, Josh Boyer wrote: >> On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez >> wrote: >> > From: David Howells >> > >> > We'll want to reuse this same code later in order to >> > read two separate typ

Re: [PATCH v2 4/5] firmware: generalize reading file contents as a helper

2015-10-08 Thread Luis R. Rodriguez
On Thu, Oct 08, 2015 at 01:36:53PM -0400, Josh Boyer wrote: > On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez > wrote: > > From: David Howells > > > > We'll want to reuse this same code later in order to > > read two separate types of file contents. This generalizes > > fw_read_file() for readi

Re: [PATCH v2 4/5] firmware: generalize reading file contents as a helper

2015-10-08 Thread Josh Boyer
On Thu, Oct 1, 2015 at 1:44 PM, Luis R. Rodriguez wrote: > From: David Howells > > We'll want to reuse this same code later in order to > read two separate types of file contents. This generalizes > fw_read_file() for reading a file rebrands it as fw_read_file(). Er, maybe that should read "...f