Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-07-01 Thread Srinivas Pandruvada
On Wed, 2020-07-01 at 18:31 +0200, Daniel Lezcano wrote: > On 01/07/2020 17:49, Srinivas Pandruvada wrote: > > [...] > > > > > Then I'd prefer we only introduce the events that are used or > > > will be > > > used soon, like the tz disable/enable, to avoid some potential > > > dead > > > code. > >

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-07-01 Thread Daniel Lezcano
On 01/07/2020 17:49, Srinivas Pandruvada wrote: > > [...] > >> Then I'd prefer we only introduce the events that are used or will be >> used soon, like the tz disable/enable, to avoid some potential dead >> code. >> We can easily add more events when they are needed. >> >> Srinivas, do you have p

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-07-01 Thread Srinivas Pandruvada
[...] > Then I'd prefer we only introduce the events that are used or will be > used soon, like the tz disable/enable, to avoid some potential dead > code. > We can easily add more events when they are needed. > > Srinivas, do you have plan to use the trip add/delete events? Yes and also trip m

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-07-01 Thread Daniel Lezcano
On 01/07/2020 09:41, Zhang Rui wrote: > Hi, Daniel, > > On Tue, 2020-06-30 at 20:32 +0200, Daniel Lezcano wrote: >> Hi Zhang, >> >> thanks for taking the time to review >> >> >> On 30/06/2020 18:12, Zhang Rui wrote: >> >> [ ... ] >> +int thermal_notify_tz_enable(int tz_id); +int thermal_

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-07-01 Thread Zhang Rui
Hi, Daniel, On Tue, 2020-06-30 at 20:32 +0200, Daniel Lezcano wrote: > Hi Zhang, > > thanks for taking the time to review > > > On 30/06/2020 18:12, Zhang Rui wrote: > > [ ... ] > > > > +int thermal_notify_tz_enable(int tz_id); > > > +int thermal_notify_tz_disable(int tz_id); > > > > these t

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-06-30 Thread Daniel Lezcano
Hi Zhang, thanks for taking the time to review On 30/06/2020 18:12, Zhang Rui wrote: [ ... ] >> +int thermal_notify_tz_enable(int tz_id); >> +int thermal_notify_tz_disable(int tz_id); > > these two will be used after merging the mode enhancement patches from > Andrzej Pietrasiewicz, right?

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-06-30 Thread Zhang Rui
On Thu, 2020-06-25 at 16:45 +0200, Daniel Lezcano wrote: > Initially the thermal framework had a very simple notification > mechanism to send generic netlink messages to the userspace. > > The notification function was never called from anywhere and the > corresponding dead code was removed. It wa

Re: [PATCH v2 4/5] thermal: core: genetlink support for events/cmd/sampling

2020-06-30 Thread Amit Kucheria
On Thu, Jun 25, 2020 at 8:15 PM Daniel Lezcano wrote: > > Initially the thermal framework had a very simple notification > mechanism to send generic netlink messages to the userspace. > > The notification function was never called from anywhere and the > corresponding dead code was removed. It was