Re: [PATCH v2 4/6] bus: add driver for the Technologic Systems NBUS

2017-03-14 Thread Sebastien Bourdelin
Hi Linus, On 03/14/2017 09:23 AM, Linus Walleij wrote: > On Wed, Feb 22, 2017 at 5:56 PM, Sebastien Bourdelin > wrote: >> On 02/04/2017 05:14 AM, Linus Walleij wrote: > + gpiod_set_array_value_cansleep(gpios->ndescs, gpios->desc, values); >>> >>> This can also fail and you should chec

Re: [PATCH v2 4/6] bus: add driver for the Technologic Systems NBUS

2017-03-14 Thread Linus Walleij
On Wed, Feb 22, 2017 at 5:56 PM, Sebastien Bourdelin wrote: > On 02/04/2017 05:14 AM, Linus Walleij wrote: >>> + gpiod_set_array_value_cansleep(gpios->ndescs, gpios->desc, values); >> >> This can also fail and you should check the return code and print an error >> message if it does. >> > A

Re: [PATCH v2 4/6] bus: add driver for the Technologic Systems NBUS

2017-02-22 Thread Sebastien Bourdelin
Hi Linus, First thanks for your code review! On 02/04/2017 05:14 AM, Linus Walleij wrote: > On Fri, Feb 3, 2017 at 8:47 PM, Sebastien Bourdelin > wrote: > >> This driver implements a GPIOs bit-banged bus, called the NBUS by >> Technologic Systems. It is used to communicate with the peripherals

Re: [PATCH v2 4/6] bus: add driver for the Technologic Systems NBUS

2017-02-04 Thread Linus Walleij
On Fri, Feb 3, 2017 at 8:47 PM, Sebastien Bourdelin wrote: > This driver implements a GPIOs bit-banged bus, called the NBUS by > Technologic Systems. It is used to communicate with the peripherals in > the FPGA on the TS-4600 SoM. > > --- > Changes v1 -> v2: > - rebase on master > - the drive