Re: [PATCH v2 4/7] gpio: mockup: improve readability

2017-05-31 Thread Bartosz Golaszewski
2017-05-31 16:57 GMT+02:00 Andy Shevchenko : > On Wed, May 31, 2017 at 1:53 PM, Bartosz Golaszewski wrote: >> 2017-05-30 20:55 GMT+02:00 Andy Shevchenko : >>> On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski wrote: We currently shift bits here and there without actually explaining

Re: [PATCH v2 4/7] gpio: mockup: improve readability

2017-05-31 Thread Andy Shevchenko
On Wed, May 31, 2017 at 1:53 PM, Bartosz Golaszewski wrote: > 2017-05-30 20:55 GMT+02:00 Andy Shevchenko : >> On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski wrote: >>> We currently shift bits here and there without actually explaining >>> what we're doing. Add some helper variables with na

Re: [PATCH v2 4/7] gpio: mockup: improve readability

2017-05-31 Thread Bartosz Golaszewski
2017-05-30 20:55 GMT+02:00 Andy Shevchenko : > On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski wrote: >> We currently shift bits here and there without actually explaining >> what we're doing. Add some helper variables with names indicating >> their purpose to improve the code readability. >

Re: [PATCH v2 4/7] gpio: mockup: improve readability

2017-05-30 Thread Andy Shevchenko
On Tue, May 30, 2017 at 11:58 AM, Bartosz Golaszewski wrote: > We currently shift bits here and there without actually explaining > what we're doing. Add some helper variables with names indicating > their purpose to improve the code readability. > + /* Each chip is described by two values.