Re: [PATCH v2 4/9] xen/pvh: Bootstrap PVH guest

2017-02-03 Thread Juergen Gross
On 03/02/17 17:20, Boris Ostrovsky wrote: > >>> + >>> + __HEAD >>> + >>> +/* Entry point for PVH guests. */ >> Could you add some comments about register conetnts at entry? > > Reference to Xen's docs/misc/hvmlite.markdown would be sifficient? I think the corresponding lines should be copied t

Re: [PATCH v2 4/9] xen/pvh: Bootstrap PVH guest

2017-02-03 Thread Boris Ostrovsky
>> + >> +__HEAD >> + >> +/* Entry point for PVH guests. */ > Could you add some comments about register conetnts at entry? Reference to Xen's docs/misc/hvmlite.markdown would be sifficient? >> +gdt: >> +.word gdt_end - gdt >> +.long _pa(gdt) > This is a rather strange construc

Re: [PATCH v2 4/9] xen/pvh: Bootstrap PVH guest

2017-02-02 Thread Juergen Gross
On 26/01/17 20:41, Boris Ostrovsky wrote: > Start PVH guest at XEN_ELFNOTE_PHYS32_ENTRY address. Setup hypercall > page, initialize boot_params, enable early page tables. > > Since this stub is executed before kernel entry point we cannot use > variables in .bss which is cleared by kernel. We expl