Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-19 Thread James Simmons
> On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > >>> In order for lustre_idl.h to be usable for both user > > >>> land and kernel space it

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-13 Thread Dan Carpenter
On Tue, Dec 13, 2016 at 11:14:26AM -0500, Oleg Drokin wrote: > > On Dec 13, 2016, at 3:31 AM, Dan Carpenter wrote: > > > It used to be that great swathes of Lustre were used in both user space > > and kernel space. We had huge unused modules in the kernel that were > > only used for user space.

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-13 Thread Oleg Drokin
On Dec 13, 2016, at 3:31 AM, Dan Carpenter wrote: > It used to be that great swathes of Lustre were used in both user space > and kernel space. We had huge unused modules in the kernel that were > only used for user space. Huh? There was nothing of the sort. There were huge parts of code that w

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-13 Thread Dan Carpenter
It used to be that great swathes of Lustre were used in both user space and kernel space. We had huge unused modules in the kernel that were only used for user space. regards, dan carpenter

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-12 Thread Greg Kroah-Hartman
On Tue, Dec 13, 2016 at 12:55:01AM +, Dilger, Andreas wrote: > On Dec 12, 2016, at 13:00, James Simmons wrote: > > > > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > >>> In order for lustre_idl.h to be usable for both user > >>> land and kernel space it has to use the

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-12 Thread Dilger, Andreas
On Dec 12, 2016, at 13:00, James Simmons wrote: > > >> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: >>> In order for lustre_idl.h to be usable for both user >>> land and kernel space it has to use the proper >>> byteorder functions. >> >> Why would userspace need/want all of t

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-12 Thread Greg Kroah-Hartman
On Mon, Dec 12, 2016 at 08:00:02PM +, James Simmons wrote: > > > On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > > In order for lustre_idl.h to be usable for both user > > > land and kernel space it has to use the proper > > > byteorder functions. > > > > Why would userspac

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-12 Thread James Simmons
> On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > > In order for lustre_idl.h to be usable for both user > > land and kernel space it has to use the proper > > byteorder functions. > > Why would userspace need/want all of these inline functions? A uapi > header file should just

Re: [PATCH v2 5/5] staging: lustre: headers: use proper byteorder functions in lustre_idl.h

2016-12-10 Thread Greg Kroah-Hartman
On Sat, Dec 10, 2016 at 01:06:01PM -0500, James Simmons wrote: > In order for lustre_idl.h to be usable for both user > land and kernel space it has to use the proper > byteorder functions. Why would userspace need/want all of these inline functions? A uapi header file should just have a the stru