Re: [PATCH v2 5/7] arm64: make arm uprobes code reusable by arm64

2018-10-02 Thread Julien Thierry
Hi, On 01/10/18 14:28, Maciej Slodczyk wrote: Hi, Thank you for the review. I think that it would be good to move the renaming changes out of this patch. So, as I understand, you suggest separating renaming from moving and putting it in separate patches, right? Yes, I just feel this pat

Re: [PATCH v2 5/7] arm64: make arm uprobes code reusable by arm64

2018-10-01 Thread Maciej Slodczyk
Hi, Thank you for the review. > I think that it would be good to move the renaming changes out of this > patch. > So, as I understand, you suggest separating renaming from moving and putting it in separate patches, right? >>   }) >> +#define ARM_COMPAT_LR_OFFSET    0 > > Not sure this shoul

Re: [PATCH v2 5/7] arm64: make arm uprobes code reusable by arm64

2018-09-27 Thread Julien Thierry
Hi Maciej, I think that it would be good to move the renaming changes out of this patch. On 26/09/18 13:12, Maciej Slodczyk wrote: There are many segments of ARM32 uprobes code that is very specific to 32-bit ARM arch and many differences between the two architectures that could be made porta