Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

2017-08-07 Thread Kani, Toshimitsu
On Sat, 2017-08-05 at 07:49 +0200, Borislav Petkov wrote: > On Fri, Aug 04, 2017 at 09:48:23PM +, Kani, Toshimitsu wrote: > > Not sure if anyone cares, but I thought it should return with > > -ENODEV when this modules found no target, and -EBUSY when it found > > a target but it's busy.  Hence,

Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

2017-08-04 Thread Borislav Petkov
On Fri, Aug 04, 2017 at 09:48:23PM +, Kani, Toshimitsu wrote: > Not sure if anyone cares, but I thought it should return with -ENODEV > when this modules found no target, and -EBUSY when it found a target > but it's busy. Hence, this ordering. You can still return -EBUSY. Just do the owner ch

Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

2017-08-04 Thread Kani, Toshimitsu
On Fri, 2017-08-04 at 10:39 +0200, Borislav Petkov wrote: > On Thu, Aug 03, 2017 at 03:57:53PM -0600, Toshi Kani wrote: > > Change generic x86 edac drivers, which probe CPU type with > > x86_match_cpu(), to call edac_check_mc_owner() in their > > module init functions.  This allows them to fail the

Re: [PATCH v2 7/7] edac drivers: add MC owner check in init

2017-08-04 Thread Borislav Petkov
On Thu, Aug 03, 2017 at 03:57:53PM -0600, Toshi Kani wrote: > Change generic x86 edac drivers, which probe CPU type with > x86_match_cpu(), to call edac_check_mc_owner() in their > module init functions. This allows them to fail their init > at the beginning when ghes_edac is enabled. Similar cha