Re: [PATCH v2 7/8] rtc: implement a sysfs interface for clock offset

2016-02-02 Thread Alexandre Belloni
On 01/02/2016 at 12:56:48 -0800, Joshua Clayton wrote : > > I'm fine with having parts per billion as the unit and I hope we won't > > ever need anything more precise :) > > > It is orders of magnitude more than needed at present Yeah, until we get an RTC with an offset precision that has 4 decim

Re: [PATCH v2 7/8] rtc: implement a sysfs interface for clock offset

2016-02-01 Thread Joshua Clayton
On Sun, 31 Jan 2016 12:41:15 +0100 Alexandre Belloni wrote: > Hi, > > On 04/01/2016 at 10:31:25 -0800, Joshua Clayton wrote : > > The file is called "offset", and may be set and read in decimal. > > For rtcs that do not have read_offset or set_offset implemented, > > read always returns zero and

Re: [PATCH v2 7/8] rtc: implement a sysfs interface for clock offset

2016-01-31 Thread Alexandre Belloni
Hi, On 04/01/2016 at 10:31:25 -0800, Joshua Clayton wrote : > The file is called "offset", and may be set and read in decimal. > For rtcs that do not have read_offset or set_offset implemented, > read always returns zero and write will return -EINVAL. > Can you expand rtc_attr_is_visible() instea