Re: [PATCH v2 8/9] bfs: remove multiple assignments

2008-01-30 Thread Dmitri Vorobiev
Al Viro wrote: > On Mon, Jan 28, 2008 at 01:02:03AM -0600, Joel Schopp wrote: > -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; > +inode->i_mtime = CURRENT_TIME_SEC; > +inode->i_atime = CURRENT_TIME_SEC; > +inode->i_ctime = CURRENT_TIME_SEC; >>>

Re: [PATCH v2 8/9] bfs: remove multiple assignments

2008-01-30 Thread Al Viro
On Mon, Jan 28, 2008 at 01:02:03AM -0600, Joel Schopp wrote: > >>>-inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; > >>>+inode->i_mtime = CURRENT_TIME_SEC; > >>>+inode->i_atime = CURRENT_TIME_SEC; > >>>+inode->i_ctime = CURRENT_TIME_SEC; > >>multiple assignments

Re: [PATCH v2 8/9] bfs: remove multiple assignments

2008-01-27 Thread Joel Schopp
-inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; +inode->i_mtime = CURRENT_TIME_SEC; +inode->i_atime = CURRENT_TIME_SEC; +inode->i_ctime = CURRENT_TIME_SEC; multiple assignments like "x = y = z = value;" can potentially (depending on the compiler and arch) be

Re: [PATCH v2 8/9] bfs: remove multiple assignments

2008-01-26 Thread Dmitri Vorobiev
Tigran Aivazian wrote: > On Sat, 26 Jan 2008, Dmitri Vorobiev wrote: >> -inode->i_mtime = inode->i_atime = inode->i_ctime = CURRENT_TIME_SEC; >> +inode->i_mtime = CURRENT_TIME_SEC; >> +inode->i_atime = CURRENT_TIME_SEC; >> +inode->i_ctime = CURRENT_TIME_SEC; > > multiple assignment