Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
Hello! This v3 series contains the following fixes: 1. Rename SLAB_DESTROY_BY_RCU to SLAB_TYPESAFE_BY_RCU. 2. Use "WARNING" tag on RCU's lockdep splats. 3. Update obsolete callback_head comment. 4. Make RCU_FANOUT_LEAF help text more explicit about skew_tick. 5. Remov

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 05:43:43PM +0200, Peter Zijlstra wrote: > On Wed, Apr 19, 2017 at 08:37:03AM -0700, Paul E. McKenney wrote: > > On Wed, Apr 19, 2017 at 03:15:53PM +0200, Peter Zijlstra wrote: > > > On Wed, Apr 19, 2017 at 06:02:45AM -0700, Paul E. McKenney wrote: > > > > On Wed, Apr 19, 201

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
On Wed, Apr 19, 2017 at 08:37:03AM -0700, Paul E. McKenney wrote: > On Wed, Apr 19, 2017 at 03:15:53PM +0200, Peter Zijlstra wrote: > > On Wed, Apr 19, 2017 at 06:02:45AM -0700, Paul E. McKenney wrote: > > > On Wed, Apr 19, 2017 at 01:28:45PM +0200, Peter Zijlstra wrote: > > > > > > > > So the thi

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 03:15:53PM +0200, Peter Zijlstra wrote: > On Wed, Apr 19, 2017 at 06:02:45AM -0700, Paul E. McKenney wrote: > > On Wed, Apr 19, 2017 at 01:28:45PM +0200, Peter Zijlstra wrote: > > > > > > So the thing Maz complained about is because KVM assumes > > > synchronize_srcu() is '

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 05:03:09PM +0200, Peter Zijlstra wrote: > On Wed, Apr 19, 2017 at 07:58:44AM -0700, Josh Triplett wrote: > > > > Still something to hesitate a bit before using, but not something > > checkpatch should warn about. > > How else will you get people to hesitate? The fact that

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 04:52:15PM +0200, Peter Zijlstra wrote: > On Wed, Apr 19, 2017 at 07:47:30AM -0700, Paul E. McKenney wrote: > > The RCU expedited primitives have been completely rewritten since then, > > and no longer use try_stop_cpus(), no longer disturb idle CPUs, and no > > longer distu

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
On Wed, Apr 19, 2017 at 07:58:44AM -0700, Josh Triplett wrote: > > Still something to hesitate a bit before using, but not something > checkpatch should warn about. How else will you get people to hesitate?

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Josh Triplett
On Wed, Apr 19, 2017 at 07:47:30AM -0700, Paul E. McKenney wrote: > On Wed, Apr 19, 2017 at 02:08:47PM +0200, Peter Zijlstra wrote: > > On Wed, Apr 19, 2017 at 01:48:08PM +0200, Christian Borntraeger wrote: > > > On 04/19/2017 01:28 PM, Peter Zijlstra wrote: > > > > > > > > So the thing Maz compla

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
On Wed, Apr 19, 2017 at 07:47:30AM -0700, Paul E. McKenney wrote: > The RCU expedited primitives have been completely rewritten since then, > and no longer use try_stop_cpus(), no longer disturb idle CPUs, and no > longer disturb nohz_full CPUs running in userspace. In addition, there > is the rcu

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 02:08:47PM +0200, Peter Zijlstra wrote: > On Wed, Apr 19, 2017 at 01:48:08PM +0200, Christian Borntraeger wrote: > > On 04/19/2017 01:28 PM, Peter Zijlstra wrote: > > > > > > So the thing Maz complained about is because KVM assumes > > > synchronize_srcu() is 'free' when th

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Christian Borntraeger
On 04/19/2017 03:22 PM, Paul E. McKenney wrote: > On Wed, Apr 19, 2017 at 01:48:08PM +0200, Christian Borntraeger wrote: >> On 04/19/2017 01:28 PM, Peter Zijlstra wrote: >>> >>> So the thing Maz complained about is because KVM assumes >>> synchronize_srcu() is 'free' when there is no srcu_read_lock

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 01:48:08PM +0200, Christian Borntraeger wrote: > On 04/19/2017 01:28 PM, Peter Zijlstra wrote: > > > > So the thing Maz complained about is because KVM assumes > > synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. > > This series 'breaks' that. > > W

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
On Wed, Apr 19, 2017 at 06:02:45AM -0700, Paul E. McKenney wrote: > On Wed, Apr 19, 2017 at 01:28:45PM +0200, Peter Zijlstra wrote: > > > > So the thing Maz complained about is because KVM assumes > > synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. > > This series 'breaks'

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Paul E. McKenney
On Wed, Apr 19, 2017 at 01:28:45PM +0200, Peter Zijlstra wrote: > > So the thing Maz complained about is because KVM assumes > synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. > This series 'breaks' that. > > I've not looked hard enough at the new SRCU to see if its possib

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Marc Zyngier
On 19/04/17 13:08, Peter Zijlstra wrote: > On Wed, Apr 19, 2017 at 01:48:08PM +0200, Christian Borntraeger wrote: >> On 04/19/2017 01:28 PM, Peter Zijlstra wrote: >>> >>> So the thing Maz complained about is because KVM assumes >>> synchronize_srcu() is 'free' when there is no srcu_read_lock() acti

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
On Wed, Apr 19, 2017 at 01:48:08PM +0200, Christian Borntraeger wrote: > On 04/19/2017 01:28 PM, Peter Zijlstra wrote: > > > > So the thing Maz complained about is because KVM assumes > > synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. > > This series 'breaks' that. > > W

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Christian Borntraeger
On 04/19/2017 01:28 PM, Peter Zijlstra wrote: > > So the thing Maz complained about is because KVM assumes > synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. > This series 'breaks' that. Why is such a behaviour change not mentioned in the cover letter? I could not find any

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
On Wed, Apr 19, 2017 at 01:28:45PM +0200, Peter Zijlstra wrote: > > So the thing Maz complained about is because KVM assumes > synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. > This series 'breaks' that. Could've been call_srcu() instead. Looking at the code that trigger

Re: [PATCH v2 tip/core/rcu 0/13] Miscellaneous fixes for 4.12

2017-04-19 Thread Peter Zijlstra
So the thing Maz complained about is because KVM assumes synchronize_srcu() is 'free' when there is no srcu_read_lock() activity. This series 'breaks' that. I've not looked hard enough at the new SRCU to see if its possible to re-instate that feature.