Re: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python

2014-09-22 Thread Paul Bolle
On Mon, 2014-09-22 at 10:45 +0200, Valentin Rothberg wrote: > On lun., 2014-09-22 at 10:24 +0200, Paul Bolle wrote: > > On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote: > > > On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote: > > > 2) ./lib/Makefile: TEST_MODULE (defined in lib/Kconf

Re: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python

2014-09-22 Thread Valentin Rothberg
On lun., 2014-09-22 at 10:24 +0200, Paul Bolle wrote: > Hi Valentin, > > On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote: > > On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote: > > > Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]: > > > > Furthermore, it generates false

Re: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python

2014-09-22 Thread Paul Bolle
Hi Valentin, On Mon, 2014-09-22 at 09:43 +0200, Valentin Rothberg wrote: > On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote: > > Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]: > > > Furthermore, it generates false positives (4 of 526 in v3.17-rc1). > > > > Curiosity: what are th

Re: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python

2014-09-22 Thread Valentin Rothberg
On dim., 2014-09-21 at 23:28 +0200, Paul Bolle wrote: > Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]: > > The scripts/checkkconfigsymbols.sh script searches Kconfig features > > in the source code that are not defined in Kconfig. Such identifiers > > always evaluate to false and are

Re: [PATCH v3] checkkconfigsymbols.sh: reimplementation in python

2014-09-21 Thread Paul Bolle
Valentin Rothberg schreef op zo 21-09-2014 om 21:53 [+0200]: > The scripts/checkkconfigsymbols.sh script searches Kconfig features > in the source code that are not defined in Kconfig. Such identifiers > always evaluate to false and are the source of various kinds of bugs. > However, the shell scri