Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-25 Thread Sebastian Hesselbarth
On Wed, Mar 20, 2013 at 5:48 PM, Daniel Mack wrote: > On 20.03.2013 14:55, michal.bachr...@gmail.com wrote: >> Thanks for writing this driver! I have tested your si5351 clock >> driver and his tuning capabilities. It works well, it generates >> proper clock frequency, but when new frequency is gen

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-23 Thread Lars-Peter Clausen
On 03/21/2013 10:32 PM, Sebastian Hesselbarth wrote: >>> + >>> +dev_info(&client->dev, "registered si5351 i2c client\n"); >>> + >> >> That's just noise, imagine every driver would print such a line, your bootlog >> would be scrolling for hours ;) I'd either remove it or make it dev_dbg > > Act

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-21 Thread Sebastian Hesselbarth
On 03/21/2013 07:09 PM, Lars-Peter Clausen wrote: On 03/18/2013 11:43 AM, Sebastian Hesselbarth wrote: This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver supports DT kernels only and VXCO feature of si5351b is not implement

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-21 Thread Lars-Peter Clausen
On 03/18/2013 11:43 AM, Sebastian Hesselbarth wrote: > This patch adds a common clock driver for Silicon Labs Si5351a/b/c > i2c programmable clock generators. Currently, the driver supports > DT kernels only and VXCO feature of si5351b is not implemented. DT > bindings selectively allow to overwrit

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-20 Thread Daniel Mack
Hi Michal, On 20.03.2013 14:55, michal.bachr...@gmail.com wrote: > Thanks for writing this driver! I have tested your si5351 clock > driver and his tuning capabilities. It works well, it generates > proper clock frequency, but when new frequency is generated, little > clock gap (1ms) is generat

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-20 Thread michal . bachraty
Hi Sebastian, Thanks for writing this driver! I have tested your si5351 clock driver and his tuning capabilities. It works well, it generates proper clock frequency, but when new frequency is generated, little clock gap (1ms) is generated. Si5351 datasheet and WP claims, clock tuning can be wit

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-20 Thread Sebastian Hesselbarth
On 03/20/2013 01:26 AM, Mike Turquette wrote: Quoting Sebastian Hesselbarth (2013-03-18 03:43:17) This patch adds a common clock driver for Silicon Labs Si5351a/b/c i2c programmable clock generators. Currently, the driver supports DT kernels only and VXCO feature of si5351b is not implemented. D

Re: [PATCH v3] clk: add si5351 i2c common clock driver

2013-03-18 Thread Daniel Mack
On 18.03.2013 11:43, Sebastian Hesselbarth wrote: > This patch adds a common clock driver for Silicon Labs Si5351a/b/c > i2c programmable clock generators. Currently, the driver supports > DT kernels only and VXCO feature of si5351b is not implemented. DT > bindings selectively allow to overwrite s