Re: [PATCH v3] mm/page_alloc: add a helper function to check page before alloc/free

2015-09-09 Thread Yaowei Bai
On Wed, Sep 09, 2015 at 03:39:54PM +0200, Vlastimil Babka wrote: > On 09/08/2015 09:19 PM, Vlastimil Babka wrote: > >bloat-o-meter looks favorably with my gcc, although there shouldn't be a real > >reason for it, as the inlining didn't change: > > > >add/remove: 1/1 grow/shrink: 1/1 up/down: 285/-3

Re: [PATCH v3] mm/page_alloc: add a helper function to check page before alloc/free

2015-09-09 Thread Vlastimil Babka
On 09/08/2015 09:19 PM, Vlastimil Babka wrote: bloat-o-meter looks favorably with my gcc, although there shouldn't be a real reason for it, as the inlining didn't change: add/remove: 1/1 grow/shrink: 1/1 up/down: 285/-336 (-51) function old new delta bad

Re: [PATCH v3] mm/page_alloc: add a helper function to check page before alloc/free

2015-09-09 Thread Yaowei Bai
On Tue, Sep 08, 2015 at 09:19:07PM +0200, Vlastimil Babka wrote: > On 08/27/2015 02:51 PM, Yaowei Bai wrote: > > The major portion of check_new_page() and free_pages_check() are same, > > introduce a helper function check_one_page() for simplification. > > > > Change in v3: > > - add the misse

Re: [PATCH v3] mm/page_alloc: add a helper function to check page before alloc/free

2015-09-08 Thread Vlastimil Babka
On 08/27/2015 02:51 PM, Yaowei Bai wrote: > The major portion of check_new_page() and free_pages_check() are same, > introduce a helper function check_one_page() for simplification. > > Change in v3: > - add the missed __PG_HWPOISON check per Michal Hocko > Change in v2: > - use bad_fl