Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-04 Thread Alexander Gordeev
On Tue, Oct 02, 2012 at 12:45:26PM -0400, Jeff Garzik wrote: > >>>+ VPRINTK("ENTER\n"); > >> > >>Is this per IRQ handler execution debugging code still needed? > >>Same for the other VPRINTK() lines in this patch. > > > >These VPRINKs are only to make new handlers look like ahci_interrupt() > >whi

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-02 Thread Jeff Garzik
On 10/02/2012 12:42 PM, Alexander Gordeev wrote: On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) +{ + struct ata_port *ap_this = dev_instance; + struct ahci_port_priv *pp = ap_this->private_data; + struct

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-02 Thread Alexander Gordeev
On Tue, Oct 02, 2012 at 07:09:29AM +0200, Ingo Molnar wrote: > > +irqreturn_t ahci_hw_interrupt(int irq, void *dev_instance) > > +{ > > + struct ata_port *ap_this = dev_instance; > > + struct ahci_port_priv *pp = ap_this->private_data; > > + struct ata_host *host = ap_this->host; > > + stru

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Ingo Molnar
* Alexander Gordeev wrote: > Take advantage of multiple MSIs implementation on x86 - on systems with > IRQ remapping AHCI ports not only get assigned separate MSI vectors - > but also separate IRQs. As result, interrupts generated by different > ports could be serviced on different CPUs rather t

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
On 10/02/2012 12:21 AM, Bjorn Helgaas wrote: On Mon, Oct 1, 2012 at 9:04 PM, Jeff Garzik wrote: On 10/01/2012 04:13 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors - but al

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Bjorn Helgaas
On Mon, Oct 1, 2012 at 9:04 PM, Jeff Garzik wrote: > On 10/01/2012 04:13 AM, Alexander Gordeev wrote: >> >> Take advantage of multiple MSIs implementation on x86 - on systems with >> IRQ remapping AHCI ports not only get assigned separate MSI vectors - >> but also separate IRQs. As result, interru

Re: [PATCH v3 -tip 5/5] AHCI: Support multiple MSIs

2012-10-01 Thread Jeff Garzik
On 10/01/2012 04:13 AM, Alexander Gordeev wrote: Take advantage of multiple MSIs implementation on x86 - on systems with IRQ remapping AHCI ports not only get assigned separate MSI vectors - but also separate IRQs. As result, interrupts generated by different ports could be serviced on different