Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-18 Thread Xu Yilun
I think that's a good optimization. I'll include this change and send a v4. Thanks. On Tue, Aug 18, 2020 at 07:40:45AM -0700, Tom Rix wrote: > Yilun, > > I was looking at the tx side a bit and think the padding function could be > moved into the pkt/phy function.  The pky/phy function already i

Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-18 Thread Tom Rix
Yilun, I was looking at the tx side a bit and think the padding function could be moved into the pkt/phy function.  The pky/phy function already is looking for the eop's so reuse it and remove the search for eop and exchange the loops that do char moving and padding to mem* functions.  The logi

Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-18 Thread Xu Yilun
On Mon, Aug 17, 2020 at 10:12:52AM +0100, Lee Jones wrote: > On Mon, 17 Aug 2020, Xu Yilun wrote: > > > Hi Brown & jones: > > > > I tried to refacor the regmap code and add comments in this patchset. I > > made big changes to the rx flow and remove some tricky parts in it. > > > > Would it be mo

Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-17 Thread Lee Jones
On Mon, 17 Aug 2020, Xu Yilun wrote: > Hi Brown & jones: > > I tried to refacor the regmap code and add comments in this patchset. I > made big changes to the rx flow and remove some tricky parts in it. > > Would it be more understandable than last version? I'm expecting your > comments on it wh

Re: [PATCH v3 0/2] add regmap-spi-avmm & Intel Max10 BMC chip support

2020-08-17 Thread Xu Yilun
Hi Brown & jones: I tried to refacor the regmap code and add comments in this patchset. I made big changes to the rx flow and remove some tricky parts in it. Would it be more understandable than last version? I'm expecting your comments on it when you have time, thanks in advance. Yilun On Wed,