Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Ross Zwisler
On Mon, Apr 24, 2017 at 09:22:45AM -0400, Jeff Layton wrote: > In order to get proper error codes from fsync, we must set an error in > the mapping range when writeback fails. > > Signed-off-by: Jeff Layton Works fine in some error injection testing. Tested-by: Ross Zwisler > --- > fs/dax.c

Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Jan Kara
On Mon 24-04-17 09:22:45, Jeff Layton wrote: > In order to get proper error codes from fsync, we must set an error in > the mapping range when writeback fails. > > Signed-off-by: Jeff Layton So I'm fine with the change but please expand the changelog to something like: DAX currently doesn't set

Re: [PATCH v3 06/20] dax: set errors in mapping when writeback fails

2017-04-24 Thread Christoph Hellwig
Looks fine, Reviewed-by: Christoph Hellwig