Re: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

Hi Andy, On 2019/3/2 23:56, Andy Shevchenko wrote: > On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: >> >> This driver handles usb phy power on and shutdown for hi3660 Soc of >> Hisilicon. > > Few comments below. After fixing them, FWIW > Reviewed-by: Andy Shevchenko > >> +#define HI3660_USB_DE

Re: [PATCH v3 07/12] phy: Add usb phy support for hi3660 Soc of Hisilicon

On Sat, Mar 2, 2019 at 11:06 AM Yu Chen wrote: > > This driver handles usb phy power on and shutdown for hi3660 Soc of > Hisilicon. Few comments below. After fixing them, FWIW Reviewed-by: Andy Shevchenko > +#define HI3660_USB_DEFAULT_PHY_PARAM 0x1c466e3 A bit of description would be