RE: [PATCH v3 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-11 Thread Luck, Tony
> I wonder what's worse - comparing SKU strings - we know that from the MCE > recovery experience - or poking at maybe nonexistent MSRs? :-) > > I guess the latter is cleaner so let's try it. Vikas got beat up for comparing SKU strings, so the probe method was offered as an alternative. It's defi

Re: [PATCH v3 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-11 Thread Borislav Petkov
On Mon, Oct 10, 2016 at 11:55:45AM -0700, Luck, Tony wrote: > How about this (this diff on top of current series, but obviously we'll > fold it into part 07. > > > commit cdb05159fb91ed1f85c950c0f2c6de25f143961d > Author: Tony Luck > Date: Mon Oct 10 11:48:42 2016 -0700 > > Update the HSW

Re: [PATCH v3 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-10 Thread Luck, Tony
On Sun, Oct 09, 2016 at 06:28:23PM +0200, Borislav Petkov wrote: > On Sun, Oct 09, 2016 at 10:09:37AM -0700, Fenghua Yu wrote: > > The MSR is not guaranteed on every stepping of the family and model machine > > because some parts may have the MSR fused off. And some bits in the MSR > > may not be i

Re: [PATCH v3 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-09 Thread Borislav Petkov
On Sun, Oct 09, 2016 at 10:09:37AM -0700, Fenghua Yu wrote: > The MSR is not guaranteed on every stepping of the family and model machine > because some parts may have the MSR fused off. And some bits in the MSR > may not be implemented on some parts. And in KVM or guest, the MSR may not > implemen

Re: [PATCH v3 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-09 Thread Fenghua Yu
On Sun, Oct 09, 2016 at 01:41:16PM +0200, Borislav Petkov wrote: > On Fri, Oct 07, 2016 at 07:45:52PM -0700, Fenghua Yu wrote: > > From: Fenghua Yu > > > > Some Haswell generation CPUs support RDT, but they don't enumerate this > > using CPUID. Use rdmsr_safe() and wrmsr_safe() to probe the MSRs

Re: [PATCH v3 07/18] x86/intel_rdt: Add Haswell feature discovery

2016-10-09 Thread Borislav Petkov
On Fri, Oct 07, 2016 at 07:45:52PM -0700, Fenghua Yu wrote: > From: Fenghua Yu > > Some Haswell generation CPUs support RDT, but they don't enumerate this > using CPUID. Use rdmsr_safe() and wrmsr_safe() to probe the MSRs on > cpu model 63 (INTEL_FAM6_HASWELL_X) > > Signed-off-by: Fenghua Yu >