Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-18 Thread Marc Zyngier
Hi James, On Fri, 18 Sep 2020 10:58:45 +0100, James Morse wrote: > > Hi Marc, > > (CC: +Jon) > > On 01/09/2020 15:43, Marc Zyngier wrote: > > Change the way we deal with GIC SGIs by turning them into proper > > IRQs, and calling into the arch code to register the interrupt range > > instead

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-18 Thread James Morse
Hi Marc, (CC: +Jon) On 01/09/2020 15:43, Marc Zyngier wrote: > Change the way we deal with GIC SGIs by turning them into proper > IRQs, and calling into the arch code to register the interrupt range > instead of a callback. Your comment "This only works because we don't nest SGIs..." on this

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-18 Thread Marc Zyngier
On 2020-09-17 19:24, Jon Hunter wrote: On 17/09/2020 15:53, Jon Hunter wrote: ... next-20200916 completely broken on ARM and ARM64. Please check next-20200915 + the mentioned fix or just check https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=irq/ipi-as-irq OK, I

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Jon Hunter
On 17/09/2020 09:54, Marek Szyprowski wrote: > Hi Jon, > > On 17.09.2020 10:49, Jon Hunter wrote: >> On 17/09/2020 09:45, Marc Zyngier wrote: >>> On 2020-09-17 08:54, Jon Hunter wrote: On 17/09/2020 08:50, Marc Zyngier wrote: > On 2020-09-17 08:40, Linus Walleij wrote: >> On Wed,

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Jon Hunter
On 17/09/2020 15:53, Jon Hunter wrote: ... >> next-20200916 completely broken on ARM and ARM64. Please check >> next-20200915 + the mentioned fix or just check >> https://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git/log/?h=irq/ipi-as-irq > > OK, I have confirmed that on

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Linus Walleij
On Thu, Sep 17, 2020 at 10:49 AM Jon Hunter wrote: > Linus, what -next are you testing on? I am using next-20200916. That's what I use. But the Ux500 graphics are simple and does not use CMA and that is why I don't see this crash (I assume). Yours, Linus Walleij

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Marc Zyngier
On 2020-09-17 10:13, Marek Szyprowski wrote: [...] Linus, what -next are you testing on? I am using next-20200916. next-20200916 completely broken on ARM and ARM64. Please check next-20200915 + the mentioned fix or just check

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Marek Szyprowski
Hi Jon, On 17.09.2020 11:09, Jon Hunter wrote: > On 17/09/2020 09:54, Marek Szyprowski wrote: >> On 17.09.2020 10:49, Jon Hunter wrote: >>> On 17/09/2020 09:45, Marc Zyngier wrote: On 2020-09-17 08:54, Jon Hunter wrote: > On 17/09/2020 08:50, Marc Zyngier wrote: >> On 2020-09-17

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Jon Hunter
On 17/09/2020 09:54, Marek Szyprowski wrote: > Hi Jon, > > On 17.09.2020 10:49, Jon Hunter wrote: >> On 17/09/2020 09:45, Marc Zyngier wrote: >>> On 2020-09-17 08:54, Jon Hunter wrote: On 17/09/2020 08:50, Marc Zyngier wrote: > On 2020-09-17 08:40, Linus Walleij wrote: >> On Wed,

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Marek Szyprowski
Hi Jon, On 17.09.2020 10:49, Jon Hunter wrote: > On 17/09/2020 09:45, Marc Zyngier wrote: >> On 2020-09-17 08:54, Jon Hunter wrote: >>> On 17/09/2020 08:50, Marc Zyngier wrote: On 2020-09-17 08:40, Linus Walleij wrote: > On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: > >>

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Marc Zyngier
On 2020-09-17 09:49, Jon Hunter wrote: On 17/09/2020 09:45, Marc Zyngier wrote: On 2020-09-17 08:54, Jon Hunter wrote: So far, I have only tested this patch on Tegra20. Let me try the other failing boards this morning and see if those still fail. Tegra20 (if I remember well) is a dual A9

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Jon Hunter
On 17/09/2020 09:45, Marc Zyngier wrote: > On 2020-09-17 08:54, Jon Hunter wrote: >> On 17/09/2020 08:50, Marc Zyngier wrote: >>> Hi Linus, >>> >>> On 2020-09-17 08:40, Linus Walleij wrote: On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: > Can you try the patch below and let

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Marc Zyngier
On 2020-09-17 08:54, Jon Hunter wrote: On 17/09/2020 08:50, Marc Zyngier wrote: Hi Linus, On 2020-09-17 08:40, Linus Walleij wrote: On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: Can you try the patch below and let me know? I tried this patch and now Ux500 WORKS. So this patch is

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Jon Hunter
On 17/09/2020 08:50, Marc Zyngier wrote: > Hi Linus, > > On 2020-09-17 08:40, Linus Walleij wrote: >> On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: >> >>> Can you try the patch below and let me know? >> >> I tried this patch and now Ux500 WORKS. So this patch is definitely >> something

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Marc Zyngier
Hi Linus, On 2020-09-17 08:40, Linus Walleij wrote: On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: Can you try the patch below and let me know? I tried this patch and now Ux500 WORKS. So this patch is definitely something you should apply. - if

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-17 Thread Linus Walleij
On Wed, Sep 16, 2020 at 5:11 PM Marc Zyngier wrote: > Can you try the patch below and let me know? I tried this patch and now Ux500 WORKS. So this patch is definitely something you should apply. > - if (is_frankengic()) > -

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Marc Zyngier
Hi Linus, On 2020-09-16 15:03, Linus Walleij wrote: On Tue, Sep 1, 2020 at 4:44 PM Marc Zyngier wrote: Change the way we deal with GIC SGIs by turning them into proper IRQs, and calling into the arch code to register the interrupt range instead of a callback. Reviewed-by: Valentin Schneider

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Marc Zyngier
On 2020-09-16 17:22, Marc Zyngier wrote: On 2020-09-16 16:58, Jon Hunter wrote: On 16/09/2020 16:55, Marc Zyngier wrote: On 2020-09-16 16:46, Jon Hunter wrote: On 16/09/2020 16:10, Marc Zyngier wrote: Hi Jon, +Linus, who is facing a similar issue. On 2020-09-16 15:16, Jon Hunter wrote: Hi

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Marc Zyngier
On 2020-09-16 16:58, Jon Hunter wrote: On 16/09/2020 16:55, Marc Zyngier wrote: On 2020-09-16 16:46, Jon Hunter wrote: On 16/09/2020 16:10, Marc Zyngier wrote: Hi Jon, +Linus, who is facing a similar issue. On 2020-09-16 15:16, Jon Hunter wrote: Hi Marc, On 14/09/2020 14:06, Marek

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Linus Walleij
On Tue, Sep 1, 2020 at 4:44 PM Marc Zyngier wrote: > Change the way we deal with GIC SGIs by turning them into proper > IRQs, and calling into the arch code to register the interrupt range > instead of a callback. > > Reviewed-by: Valentin Schneider > Signed-off-by: Marc Zyngier Hmmm apart

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Jon Hunter
On 16/09/2020 16:55, Marc Zyngier wrote: > On 2020-09-16 16:46, Jon Hunter wrote: >> On 16/09/2020 16:10, Marc Zyngier wrote: >>> Hi Jon, >>> >>> +Linus, who is facing a similar issue. >>> >>> On 2020-09-16 15:16, Jon Hunter wrote: Hi Marc, On 14/09/2020 14:06, Marek Szyprowski

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Mikko Perttunen
Not sure which boards this issue is happening on, but looking at my hobby kernel's git history (from a couple of years ago, memory is a bit hazy), the commit labeled "Add support for TX2" adds code to drop from EL2 to EL1 at boot. Mikko On 9/16/20 10:06 PM, Jon Hunter wrote: On 16/09/2020

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Jon Hunter
On 16/09/2020 20:26, Mikko Perttunen wrote: > Not sure which boards this issue is happening on, but looking at my > hobby kernel's git history (from a couple of years ago, memory is a bit > hazy), the commit labeled "Add support for TX2" adds code to drop from > EL2 to EL1 at boot. I am seeing

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Jon Hunter
On 16/09/2020 17:28, Marc Zyngier wrote: ... > Make it that instead: > >  static void gic_eoimode1_eoi_irq(struct irq_data *d) >  { > +    u32 hwirq = gic_irq(d); > + > /* Do not deactivate an IRQ forwarded to a vcpu. */ > if (irqd_is_forwarded_to_vcpu(d)) > return; > > -  

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Jon Hunter
On 16/09/2020 17:22, Marc Zyngier wrote: > Do you boot form EL2? Not that I am aware of. There is no hypervisor that we are using. Jon -- nvpublic

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Marc Zyngier
Hi Jon, +Linus, who is facing a similar issue. On 2020-09-16 15:16, Jon Hunter wrote: Hi Marc, On 14/09/2020 14:06, Marek Szyprowski wrote: Hi Marc, On 01.09.2020 16:43, Marc Zyngier wrote: Change the way we deal with GIC SGIs by turning them into proper IRQs, and calling into the arch

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Jon Hunter
Hi Marc, On 14/09/2020 14:06, Marek Szyprowski wrote: > Hi Marc, > > On 01.09.2020 16:43, Marc Zyngier wrote: >> Change the way we deal with GIC SGIs by turning them into proper >> IRQs, and calling into the arch code to register the interrupt range >> instead of a callback. >> >> Reviewed-by:

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Jon Hunter
On 16/09/2020 16:10, Marc Zyngier wrote: > Hi Jon, > > +Linus, who is facing a similar issue. > > On 2020-09-16 15:16, Jon Hunter wrote: >> Hi Marc, >> >> On 14/09/2020 14:06, Marek Szyprowski wrote: >>> Hi Marc, >>> >>> On 01.09.2020 16:43, Marc Zyngier wrote: Change the way we deal

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-16 Thread Marc Zyngier
On 2020-09-16 16:46, Jon Hunter wrote: On 16/09/2020 16:10, Marc Zyngier wrote: Hi Jon, +Linus, who is facing a similar issue. On 2020-09-16 15:16, Jon Hunter wrote: Hi Marc, On 14/09/2020 14:06, Marek Szyprowski wrote: Hi Marc, On 01.09.2020 16:43, Marc Zyngier wrote: Change the way we

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-15 Thread Marc Zyngier
On 2020-09-15 09:35, Marek Szyprowski wrote: Hi Marc, On 15.09.2020 10:07, Marc Zyngier wrote: On 2020-09-15 07:48, Marek Szyprowski wrote: Both Exynos 4210 and 4412 use non-zero cpu-offset in GIC node in device-tree: arch/arm/boot/dts/exynos{4210,4412}.dtsi, so I assume that the GIC

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-15 Thread Marek Szyprowski
Hi Marc, On 15.09.2020 10:07, Marc Zyngier wrote: > On 2020-09-15 07:48, Marek Szyprowski wrote: Both Exynos 4210 and 4412 use non-zero cpu-offset in GIC node in device-tree: arch/arm/boot/dts/exynos{4210,4412}.dtsi, so I assume that the GIC registers are not banked. >>> >>>

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-15 Thread Marc Zyngier
Hi Marek, On 2020-09-15 07:48, Marek Szyprowski wrote: Hi Marc, Both Exynos 4210 and 4412 use non-zero cpu-offset in GIC node in device-tree: arch/arm/boot/dts/exynos{4210,4412}.dtsi, so I assume that the GIC registers are not banked. Annoyingly, it seems to work correctly in QEMU:

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-15 Thread Marek Szyprowski
Hi Marc, On 14.09.2020 17:09, Marc Zyngier wrote: > On 2020-09-14 14:26, Marek Szyprowski wrote: >> On 14.09.2020 15:13, Marc Zyngier wrote: >>> On 2020-09-14 14:06, Marek Szyprowski wrote: On 01.09.2020 16:43, Marc Zyngier wrote: > Change the way we deal with GIC SGIs by turning them

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-14 Thread Marc Zyngier
Marek, On 2020-09-14 14:26, Marek Szyprowski wrote: Hi Marc, On 14.09.2020 15:13, Marc Zyngier wrote: On 2020-09-14 14:06, Marek Szyprowski wrote: On 01.09.2020 16:43, Marc Zyngier wrote: Change the way we deal with GIC SGIs by turning them into proper IRQs, and calling into the arch code

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-14 Thread Marek Szyprowski
Hi Marc, On 01.09.2020 16:43, Marc Zyngier wrote: > Change the way we deal with GIC SGIs by turning them into proper > IRQs, and calling into the arch code to register the interrupt range > instead of a callback. > > Reviewed-by: Valentin Schneider > Signed-off-by: Marc Zyngier This patch

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-14 Thread Marek Szyprowski
Hi Marc, On 14.09.2020 15:13, Marc Zyngier wrote: > On 2020-09-14 14:06, Marek Szyprowski wrote: >> On 01.09.2020 16:43, Marc Zyngier wrote: >>> Change the way we deal with GIC SGIs by turning them into proper >>> IRQs, and calling into the arch code to register the interrupt range >>> instead of

Re: [PATCH v3 08/16] irqchip/gic: Configure SGIs as standard interrupts

2020-09-14 Thread Marc Zyngier
Hi Marek, On 2020-09-14 14:06, Marek Szyprowski wrote: Hi Marc, On 01.09.2020 16:43, Marc Zyngier wrote: Change the way we deal with GIC SGIs by turning them into proper IRQs, and calling into the arch code to register the interrupt range instead of a callback. Reviewed-by: Valentin