Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-10 Thread Giuseppe CAVALLARO
Hello Tien Hock On 6/10/2016 8:12 AM, Tien Hock Loh wrote: Yeah the PCS support for TSE is Altera. To avoid confusion, let's rename > > them, would altr_tse_pcs.[hc] be good? I don't think creating a > > sub-directory with only 2 files is necessary though. > > ok for two files w/o sub-dir. > >

Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-09 Thread Tien Hock Loh
Hi Peppe, On Wed, 2016-06-08 at 23:20 +, Giuseppe CAVALLARO wrote: > Hello Tien Hock > > On 6/9/2016 7:48 AM, Tien Hock Loh wrote: > > [snip] > > >>> .../devicetree/bindings/net/socfpga-dwmac.txt | 4 + > >>> drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- > >>> .../ne

Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-09 Thread Tien Hock Loh
Hi Peppe, On Tue, 2016-06-07 at 10:30 +0200, Giuseppe CAVALLARO wrote: > Hello > > On 6/7/2016 5:01 AM, th...@altera.com wrote: > > From: Tien Hock Loh > > > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > > the dwmac is set to sgmii > > > > Signed-off-by: Tien Hoc

Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-08 Thread Giuseppe CAVALLARO
Hello Tien Hock On 6/9/2016 7:48 AM, Tien Hock Loh wrote: [snip] .../devicetree/bindings/net/socfpga-dwmac.txt | 4 + drivers/net/ethernet/stmicro/stmmac/Makefile | 2 +- .../net/ethernet/stmicro/stmmac/dwmac-socfpga.c| 140 +-- drivers/net/ethernet/stmicro/stmmac/t

Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-08 Thread Rob Herring
On Mon, Jun 06, 2016 at 08:01:56PM -0700, th...@altera.com wrote: > From: Tien Hock Loh > > This adds support for TSE PCS that uses SGMII adapter when the phy-mode of > the dwmac is set to sgmii > > Signed-off-by: Tien Hock Loh > > --- > v2: > - Refactored the TSE PCS out from the dwmac-socfpg

Re: [PATCH v3 1/1] net: ethernet: Add TSE PCS support to dwmac-socfpga

2016-06-07 Thread Giuseppe CAVALLARO
Hello On 6/7/2016 5:01 AM, th...@altera.com wrote: From: Tien Hock Loh This adds support for TSE PCS that uses SGMII adapter when the phy-mode of the dwmac is set to sgmii Signed-off-by: Tien Hock Loh --- v2: - Refactored the TSE PCS out from the dwmac-socfpga.c file - Added binding documen